Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: Add cdn 'Origin type' argument #56

Closed
hashibot opened this issue Jun 13, 2017 · 2 comments · Fixed by #149
Closed

provider/azurerm: Add cdn 'Origin type' argument #56

hashibot opened this issue Jun 13, 2017 · 2 comments · Fixed by #149

Comments

@hashibot
Copy link

This issue was originally opened by @razsha as hashicorp/terraform#13373. It was migrated here as part of the provider split. The original body of the issue is below.


Hi,

Azure CDN Endpoint require choosing 'Origin type'.
Azure SDK GO : https://github.com/Azure/azure-sdk-for-go/blob/eb9eddfb7d680dca671221dba9e47626dd5fb464/arm/cdn/models.go
Azure Docs: https://docs.microsoft.com/en-us/azure/cdn/cdn-create-new-endpoint

Thanks,
Raz.

@tombuildsstuff
Copy link
Contributor

Hey @razsha

Thanks for opening this issue :)

Taking a quick look at this issue - the Origin Type field appears to be an Azure Portal only feature. When looking at the API responses and the ARM Templates - I don't see any reference to it, instead they're just providing a friendlier UI to populate the origin.host_name / origin_host_header fields.

For example here's the ARM Templates for Custom Origin / Storage Account / Web Apps - which map to the API.

In the Models, the field Type refers to the Resource Manager type (in this case Microsoft.Cdn/Profiles/Endpoints) - and not the Origin Type.

Given all this I don't believe there's a field for us to add to the azurerm_cdn_endpoint resource - instead I believe we should update the documentation to refer to a Storage Account and a Web App - for which I've opened PR #149

Thanks!

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants