Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CosmosDB (DocumentDB) Accounts #108

Merged
merged 12 commits into from
Jun 27, 2017
Merged

CosmosDB (DocumentDB) Accounts #108

merged 12 commits into from
Jun 27, 2017

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jun 14, 2017

Porting this over from the main repository / hashicorp/terraform#11499

@tombuildsstuff tombuildsstuff changed the title [WIP] CosmosDB (DocumentDB) Accounts CosmosDB (DocumentDB) Accounts Jun 21, 2017
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -run TestAccAzureRMCosmosDB -timeout 300m

=== RUN   TestAccAzureRMCosmosDBAccount_importBoundedStaleness
--- PASS: TestAccAzureRMCosmosDBAccount_importBoundedStaleness (767.53s)
=== RUN   TestAccAzureRMCosmosDBAccount_importBoundedStalenessComplete
--- PASS: TestAccAzureRMCosmosDBAccount_importBoundedStalenessComplete (761.12s)
=== RUN   TestAccAzureRMCosmosDBAccount_importEventualConsistency
--- PASS: TestAccAzureRMCosmosDBAccount_importEventualConsistency (760.73s)
=== RUN   TestAccAzureRMCosmosDBAccount_importSession
--- PASS: TestAccAzureRMCosmosDBAccount_importSession (742.40s)
=== RUN   TestAccAzureRMCosmosDBAccount_importStrong
--- PASS: TestAccAzureRMCosmosDBAccount_importStrong (764.82s)
=== RUN   TestAccAzureRMCosmosDBAccount_importGeoReplicated
--- PASS: TestAccAzureRMCosmosDBAccount_importGeoReplicated (1606.67s)
=== RUN   TestAccAzureRMCosmosDBAccountName_validation
--- PASS: TestAccAzureRMCosmosDBAccountName_validation (0.00s)
=== RUN   TestAccAzureRMCosmosDBAccount_boundedStaleness
--- PASS: TestAccAzureRMCosmosDBAccount_boundedStaleness (1012.67s)
=== RUN   TestAccAzureRMCosmosDBAccount_boundedStalenessComplete
--- PASS: TestAccAzureRMCosmosDBAccount_boundedStalenessComplete (745.02s)
=== RUN   TestAccAzureRMCosmosDBAccount_eventualConsistency
--- PASS: TestAccAzureRMCosmosDBAccount_eventualConsistency (751.21s)
=== RUN   TestAccAzureRMCosmosDBAccount_session
--- PASS: TestAccAzureRMCosmosDBAccount_session (758.07s)
=== RUN   TestAccAzureRMCosmosDBAccount_strong
--- PASS: TestAccAzureRMCosmosDBAccount_strong (777.53s)
=== RUN   TestAccAzureRMCosmosDBAccount_geoReplicated
--- PASS: TestAccAzureRMCosmosDBAccount_geoReplicated (2330.66s)


* `consistency_level` - (Required) The Consistency Level to use for this CosmosDB Account - can be either `BoundedStaleness`, `Eventual`, `Session` or `Strong`.
* `max_interval_in_seconds` - (Optional) When used with the Bounded Staleness consistency level, this value represents the time amount of staleness (in seconds) tolerated. Accepted range for this value is 1 - 100. Defaults to `5`. Required when `consistency_level` is set to `BoundedStaleness`.
* `max_staleness` - (Optional) When used with the Bounded Staleness consistency level, this value represents the number of stale requests tolerated. Accepted range for this value is 1 – 2,147,483,647. Defaults to `100`. Required when `consistency_level` is set to `BoundedStaleness`.
Copy link
Contributor Author

@tombuildsstuff tombuildsstuff Jun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context: the Azure API's won't allow this field to be set to any value unless consistency_level is set to BoundedStaleness

I'm unsure if that's an API bug, or intentional design decision - that's my only concern with this PR AFAIK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just make that a NOTE in the docs

@tombuildsstuff tombuildsstuff requested a review from stack72 June 21, 2017 21:12
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 1cc3c0f into master Jun 27, 2017
@tombuildsstuff tombuildsstuff deleted the documentdb branch June 27, 2017 15:30
tombuildsstuff added a commit that referenced this pull request Jun 27, 2017
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants