Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Service / Function Apps: support for updating #1125

Merged
merged 6 commits into from
Apr 23, 2018
Merged

App Service / Function Apps: support for updating #1125

merged 6 commits into from
Apr 23, 2018

Commits on Apr 14, 2018

  1. Enabling updates for App Services, which breaks the following test: 

    ```
$ acctests azurerm TestAccAzureRMAppService_tagsUpdate
=== RUN   TestAccAzureRMAppService_tagsUpdate
--- FAIL: TestAccAzureRMAppService_tagsUpdate (109.41s)
	testing.go:513: Step 1 error: Check failed: Check 2/4 error: azurerm_app_service.test: Attribute 'tags.%' expected "2", got "1"
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-azurerm/azurerm	109.444s
```
    @tombuildsstuff
    tombuildsstuff committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    a9b9213 View commit details
    Browse the repository at this point in the history

  2. Updating the app service properties on an update 

    ```
$ acctests azurerm TestAccAzureRMAppService_tagsUpdate
=== RUN   TestAccAzureRMAppService_tagsUpdate
--- PASS: TestAccAzureRMAppService_tagsUpdate (144.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	144.156s
```
    @tombuildsstuff
    tombuildsstuff committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    b2ee4d1 View commit details
    Browse the repository at this point in the history

  3. Added a test to handle updating function apps

    @tombuildsstuff
    tombuildsstuff committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    e2f71d4 View commit details
    Browse the repository at this point in the history

  4. Ensuring we update function apps

    @tombuildsstuff
    tombuildsstuff committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    2be4643 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2018

  1. Updating the docs to remove the newly non-forcenew fields

    @tombuildsstuff
    tombuildsstuff committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    8ba7886 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. Ensuring we always update the app_settings 

    ```
$ acctests azurerm TestAccAzureRMFunctionApp_siteConfigMulti
=== RUN   TestAccAzureRMFunctionApp_siteConfigMulti
--- PASS: TestAccAzureRMFunctionApp_siteConfigMulti (225.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	225.693s
```
    @tombuildsstuff
    tombuildsstuff committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    2cb0ecd View commit details
    Browse the repository at this point in the history