Update PostgreSQL to GA 2017-12-01 API #1190
Conversation
| DiffSuppressFunc: ignoreCaseDiffSuppressFunc, | ||
| }, | ||
|
|
||
| "family": { |
There was a problem hiding this comment.
What is the relationship between this and "sku.name"? Because I found that "sku.name" also contains "Gen4" or "Gen5".
There was a problem hiding this comment.
All of the fields in the struct are concatenated together to form the sku.name in the form of tier_family_capacity. This is how the API's schema is defined, I thought about splitting the values out of the name, but then the individual values could not be referenced.
|
@jeffreyCline FYI I'm going to rebase this PR on top of master, since the Diff is showing changes which are already in master (but aren't in this branch) |
tombuildsstuff
force-pushed
the
u-postgresql
branch
from
a5ac0b6
to
d83ff73
Compare
There was a problem hiding this comment.
hey @jeffreyCline
Thanks for pushing the updates to this PR, apologies for the delay in reviewing this whilst we've been out. I've rebased this and pushed a couple of minor updates to match the comments I raised in the MySQL PR and this now LGTM. I'll test the upgrade path shortly (and I've just kicked off the test suite) 👍
Thanks!
|
@jeffreyCline actually in testing this I've found a couple of bugs in this and MySQL regarding SKU's - I'll push a couple of commits to enable SKU changes without forcing a new resource - which is supported for some options:
|
- Switching SKU to a List instead of a Set - Support for updating the Capacity of a Given SKU - Tests to update the SKU's for Postgresql/MySql
|
Re-tested the upgrade path from both MySql & Postgresql -> new version and they work as expected. It's also possible to update the Capacity as in the Portal - and there's tests for this. |
|
MySQL tests pass:
|
tombuildsstuff
force-pushed
the
u-postgresql
branch
from
f9db21a
to
9133a90
Compare
|
PostgreSQL tests pass:
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Upgrade the PostgreSQL resource the adopt the GA API 2017-12-01. This PR will resolve issue #1004 .