cosmos_db_account - adding support for connection_strings
#1194
Conversation
tombuildsstuff
changed the title
cosmos_db_account - adding support for connection_strings
There was a problem hiding this comment.
Hi @thomastaylor312,
Thank you for opening this PR, it LGTM aside from this test failing:
[TestAccAzureRMCosmosDBAccount_mongoDB] [Test Output]
=== RUN TestAccAzureRMCosmosDBAccount_mongoDB
--- FAIL: TestAccAzureRMCosmosDBAccount_mongoDB (816.94s)
testing.go:513: Step 0 error: Check failed: 1 error(s) occurred:
* Check 3/3 error: azurerm_cosmosdb_account.test: Attribute 'connection_strings' expected to be set
FAIL
Once this test passes will be more then happy to get this merged in for you 🙂
|
@katbyte Thanks for the review! Where is that test output coming from? I don't see it in the travis job or when I run |
|
Answering my own question. Looks like it. Weird that it is failing because I did a manual test as well and it had the proper output. I'll dig into it and fix |
Adds connection_strings attribute to cosmos_db_account with documentation. Also adds in some missing error handling in the same function I modified for the feature.
thomastaylor312
force-pushed
the
feat/add_conn_strings
branch
from
9b55060
to
cf62668
Compare
|
Ok, should be fixed |
Updating something so teamcity can see new changes after force push.
|
Thanks, LGTM 🙂 tests now all pass: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Adds connection_strings attribute to cosmos_db_account with documentation. Also adds in some missing error handling in the same function I modified for the feature.