Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure table storage name length requirement. #143

Merged

Conversation

mjgpy3
Copy link
Contributor

@mjgpy3 mjgpy3 commented Jul 3, 2017

https://docs.microsoft.com/en-us/rest/api/storageservices/Understanding-the-Table-Service-Data-Model?redirectedfrom=MSDN#table-names.

I'm not sure if this requirement changed since this was created, but it's currently breaking my infrastructure because I have a 5-character-name table.

I'm having difficulty getting my go dev environment set up so this will likely break tests. I'll fix them once the red build comes back.

@mjgpy3
Copy link
Contributor Author

mjgpy3 commented Jul 3, 2017

Ope, guess the build didn't break. Let me know your thoughts!

@mjgpy3 mjgpy3 force-pushed the fix-azure-table-name-requirement branch from fc8a180 to 5a49ff4 Compare July 3, 2017 02:31
@mjgpy3 mjgpy3 force-pushed the fix-azure-table-name-requirement branch from 5a49ff4 to 0bb6511 Compare July 3, 2017 02:31
@tombuildsstuff
Copy link
Contributor

Hey @mjgpy3

Thanks for opening this PR - this validation change LGTM :)

Whilst the tests currently pass - would you mind adding some additional test cases to the Acceptance Test to better match the validation rules?

Thanks!

@mjgpy3
Copy link
Contributor Author

mjgpy3 commented Jul 3, 2017

Absolutely, I'll add some test as soon as I get the chance.

@mjgpy3
Copy link
Contributor Author

mjgpy3 commented Jul 4, 2017

@tombuildsstuff tests added.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mjgpy3

Thanks for pushing the latest changes. I've taken a look and this LGTM - tests pass:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 120m -run TestValidateArmStorageTableName
=== RUN   TestValidateArmStorageTableName
--- PASS: TestValidateArmStorageTableName (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	0.023s

@tombuildsstuff tombuildsstuff merged commit 0ee8630 into hashicorp:master Jul 4, 2017
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
Fix azure table storage name length requirement.
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants