Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support outbound type migration in aks service #22854

Closed
wants to merge 1 commit into from
Closed

Support outbound type migration in aks service #22854

wants to merge 1 commit into from

Conversation

MartinForReal
Copy link

@MartinForReal MartinForReal commented Aug 8, 2023

@github-actions github-actions bot added the size/S label Aug 8, 2023
@MartinForReal MartinForReal changed the title support outbound type migration in aks service Support outbound type migration in aks service Aug 8, 2023
Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
@stephybun
Copy link
Member

Thanks for this PR @MartinForReal.

Although we do support preview features before they've gone GA, talking about this internally, this particular preview feature which is related to the networking of a cluster has several constraints/rules/conditions for when it can be applied, which makes the implementation trickier. Furthermore as you're probably already aware preview features can change in behaviour over time without warning, we've seen this happen with other network related preview features in the past.

Whilst I'd like to thank you or your contribution I'm going to close this PR for the time being. We're happy to reopen and revisit this once this feature goes GA.

@stephybun stephybun closed this Aug 8, 2023
@MartinForReal
Copy link
Author

This feature is now GA.

@MartinForReal
Copy link
Author

@stephybun Do you think If we can reopen this pr again?

@stephybun
Copy link
Member

@MartinForReal this has been completed by #25021

Copy link

github-actions bot commented May 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants