azurerm_api_management_api_policy, azurerm_api_management_api_operation_policy, azurerm_api_management_product_policy : fix parsing resource id error

[sinbai]

For resources azurerm_api_management_api_policy, azurerm_api_management_api_operation_policy, azurerm_api_management_product_policy, after importing the resource using a version before v3.70.0 of Terraform Provider, the id in state file ends with "/policies/policy", and the id in state file ends with "/policies/xml" when creating resource by Terraform. Therefore, when migrating Pandora SDK, both cases need to be migrated.

In PR #22783 only the case where the ID ends with "/policies/xml" is processed, so submit this PR to process the case where the ID ends with "/policies/policy" to solve the parsing id error.

Might fix issue #23112, #23095.

Local manual testing, the steps are as follows:

1. Import the existing resources azurerm_api_management_api_policy, azurerm_api_management_api_operation_policy, azurerm_api_management_product_policy using TF provider v3.69.0.
2. Upgrade TF provider to v3.71.0.
3. Run "terraform plan" => The parsing id error occurred.
4. Upgrade the TF provider to the current PR build version.
5. Run "terraform plan" => No error.

[tombuildsstuff]

hey @sinbai

Thanks for this PR - taking a look through on the whole this looks pretty good but since we're updating these IDs we should also look to parse/reformat the ID too to ensure that the resourceGroups and other segments are correct at the same time. However if we can fix that up then this should otherwise be good to go 👍

Thanks!

[tombuildsstuff]

can we parse the updated ID and reformat it such that we can ensure the resourceGroups and other segments are correct too? e.g.:

Suggested change

	newId := strings.TrimSuffix(oldId, "/policies/policy")
	log.Printf("[DEBUG] Updating ID from %q to %q", oldId, newId)
	rawState["id"] = newId
	newId := strings.TrimSuffix(oldId, "/policies/policy")
	parsed, err := policy.ParseServiceID(newID)
	if err != nil {
	return err
	}
	newId = parsed.ID()
	log.Printf("[DEBUG] Updating ID from %q to %q", oldId, newId)
	rawState["id"] = newId

[sinbai]

Fixed.

[tombuildsstuff]

(same here / as above)

[sinbai]

Fixed.

[tombuildsstuff]

(same here)

Suggested change

	newId := strings.TrimSuffix(oldId, "/policies/policy")
	log.Printf("[DEBUG] Updating ID from %q tmakeo %q", oldId, newId)
	rawState["id"] = newId
	newId := strings.TrimSuffix(oldId, "/policies/policy")
	log.Printf("[DEBUG] Updating ID from %q to %q", oldId, newId)
	rawState["id"] = newId

[sinbai]

Fixed.

[sinbai]

hey @sinbai

Thanks for this PR - taking a look through on the whole this looks pretty good but since we're updating these IDs we should also look to parse/reformat the ID too to ensure that the resourceGroups and other segments are correct at the same time. However if we can fix that up then this should otherwise be good to go 👍

Thanks!

Hi @tombuildsstuff , thanks for your feedback. The code has been updated. Could you please take another look?

[stephybun]

LGTM 🪐

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.