New Resource: `azurerm_application_load_balancer_frontend` #23411

ziyeqf · 2023-09-28T06:27:22Z

azurerm_application_load_balancer is also affected, and also tested.

test

❯ tftest servicenetworking TestAccApplicationLoadBalancer
=== RUN   TestAccApplicationLoadBalancerFrontend_basic
=== PAUSE TestAccApplicationLoadBalancerFrontend_basic
=== RUN   TestAccApplicationLoadBalancerFrontend_complete
=== PAUSE TestAccApplicationLoadBalancerFrontend_complete
=== RUN   TestAccApplicationLoadBalancerFrontend_update
=== PAUSE TestAccApplicationLoadBalancerFrontend_update
=== RUN   TestAccApplicationLoadBalancerFrontend_requiresImport
=== PAUSE TestAccApplicationLoadBalancerFrontend_requiresImport
=== RUN   TestAccApplicationLoadBalancer_basic
=== PAUSE TestAccApplicationLoadBalancer_basic
=== RUN   TestAccApplicationLoadBalancer_complete
=== PAUSE TestAccApplicationLoadBalancer_complete
=== RUN   TestAccApplicationLoadBalancer_update
=== PAUSE TestAccApplicationLoadBalancer_update
=== RUN   TestAccApplicationLoadBalancer_requiresImport
=== PAUSE TestAccApplicationLoadBalancer_requiresImport
=== CONT  TestAccApplicationLoadBalancerFrontend_basic
=== CONT  TestAccApplicationLoadBalancer_basic
=== CONT  TestAccApplicationLoadBalancer_update
=== CONT  TestAccApplicationLoadBalancer_requiresImport
=== CONT  TestAccApplicationLoadBalancer_complete
=== CONT  TestAccApplicationLoadBalancerFrontend_update
=== CONT  TestAccApplicationLoadBalancerFrontend_requiresImport
=== CONT  TestAccApplicationLoadBalancerFrontend_complete
--- PASS: TestAccApplicationLoadBalancer_requiresImport (662.87s)
--- PASS: TestAccApplicationLoadBalancer_basic (675.26s)
--- PASS: TestAccApplicationLoadBalancerFrontend_complete (695.94s)
--- PASS: TestAccApplicationLoadBalancer_update (737.62s)
--- PASS: TestAccApplicationLoadBalancer_complete (751.68s)
--- PASS: TestAccApplicationLoadBalancerFrontend_requiresImport (770.02s)
--- PASS: TestAccApplicationLoadBalancerFrontend_basic (778.00s)
--- PASS: TestAccApplicationLoadBalancerFrontend_update (919.29s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/servicenetworking     919.373s

tombuildsstuff

hey @ziyeqf

Thanks for this PR - I've taken a look through and left some comments inline, but I'm unsure why we've reverted the naming back to as in the previous PR, so can we fix this?

Thanks!

...services/servicenetworking/service_networking_application_load_balancer_frontend_resource.go

website/docs/r/service_networking_application_load_balancer.html.markdown

website/docs/r/service_networking_application_load_balancer_frontend.html.markdown

...services/servicenetworking/service_networking_application_load_balancer_frontend_resource.go

internal/services/servicenetworking/service_networking_application_load_balancer_resource.go

...nal/services/servicenetworking/service_networking_application_load_balancer_resource_test.go

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

ziyeqf · 2023-10-12T02:51:31Z

new test

terraform-provider-azurerm [ tengzh/alb/frontend][$⇡] [🐹 v1.21.1]
❯ tftest servicenetworking TestAccApplicationLoadBalancerFrontend
=== RUN   TestAccApplicationLoadBalancerFrontend_basic
=== PAUSE TestAccApplicationLoadBalancerFrontend_basic
=== RUN   TestAccApplicationLoadBalancerFrontend_complete
=== PAUSE TestAccApplicationLoadBalancerFrontend_complete
=== RUN   TestAccApplicationLoadBalancerFrontend_update
=== PAUSE TestAccApplicationLoadBalancerFrontend_update
=== RUN   TestAccApplicationLoadBalancerFrontend_requiresImport
=== PAUSE TestAccApplicationLoadBalancerFrontend_requiresImport
=== CONT  TestAccApplicationLoadBalancerFrontend_basic
=== CONT  TestAccApplicationLoadBalancerFrontend_update
=== CONT  TestAccApplicationLoadBalancerFrontend_requiresImport
=== CONT  TestAccApplicationLoadBalancerFrontend_complete
--- PASS: TestAccApplicationLoadBalancerFrontend_update (742.62s)
--- PASS: TestAccApplicationLoadBalancerFrontend_basic (756.34s)
--- PASS: TestAccApplicationLoadBalancerFrontend_requiresImport (759.31s)
--- PASS: TestAccApplicationLoadBalancerFrontend_complete (812.33s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/servicenetworking     812.387s

~~the CI failure seems caused by some loading reason, I do not have permision to re-trigger it. Could you please re-run it?~~

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

catriona-m

Hi @ziyeqf - thanks for fixing this up, I left two minor comments but overall this is looking good! Thanks!

internal/services/servicenetworking/application_load_balancer_frontend_resource.go

…frontend_resource.go Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>

katbyte

LGTM aside from a couple comments ⛈️

internal/services/servicenetworking/application_load_balancer_frontend_resource.go

internal/services/servicenetworking/application_load_balancer_resource.go

internal/services/servicenetworking/application_load_balancer_frontend_resource_test.go

katbyte

LGTM aside from a couple comments ⛈️

katbyte

LGTM aside from a couple comments ⛈️

…frontend_resource.go

…frontend_resource_test.go

…resource.go

<Actions> <action id="4a39167e811ac038e4a588362092472c27cfbe9e4929ae61d035f708a093a669"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.76.0" to "3.77.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.77.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.77.0
FEATURES:

* New Resources: `azurerm_application_load_balancer_frontend` ([#23411](hashicorp/terraform-provider-azurerm#23411 New Resources: `azurerm_dev_center` ([#23538](hashicorp/terraform-provider-azurerm#23538 New Resources: `azurerm_dev_center_project` ([#23538](https://github.com/hashicorp/terraform-provider-azurerm/issues/23538))

ENHANCEMENTS:

* dependencies: updating to `v0.62.0` of `github.com/hashicorp/go-azure-helpers` ([#23581](hashicorp/terraform-provider-azurerm#23581 dependencies: updating Kusto SDK from `2023-05-02` to `2023-08-15` ([#23598](hashicorp/terraform-provider-azurerm#23598 dependencies: updating nginx from `2022-08-01` to `2023-04-01` ([#23583](hashicorp/terraform-provider-azurerm#23583 `netapp`: updating to use API Version `2023-05-01` ([#23576](hashicorp/terraform-provider-azurerm#23576 `springcloud`: updating to use API Version `2023-09-01-preview` ([#23544](hashicorp/terraform-provider-azurerm#23544 `storage`: updating to use API Version `2023-01-01` ([#23543](hashicorp/terraform-provider-azurerm#23543 `internal/sdk`: fixing an issue where struct fields containing `removedInNextMajorVersion` wouldn't be decoded correctly ([#23564](hashicorp/terraform-provider-azurerm#23564 `internal/sdk`: struct tag parsing is now handled consistently during both encoding and decoding ([#23568](hashicorp/terraform-provider-azurerm#23568 provider: the `roll_instances_when_required` provider feature in the `virtual_machine_scale_set` block is now optional ([#22976](hashicorp/terraform-provider-azurerm#22976 Data Source: `azurerm_automation_account`: refactoring the remaining usage of `Azure/azure-sdk-for-go` to use `hashicorp/go-azure-sdk` ([#23555](hashicorp/terraform-provider-azurerm#23555 `azurerm_automation_account`: refactoring the remaining usage of `Azure/azure-sdk-for-go` to use `hashicorp/go-azure-sdk` ([#23555](hashicorp/terraform-provider-azurerm#23555 `azurerm_resource_deployment_script_azure_cli` - improve validation for the `version` property to support newer versions ([#23370](hashicorp/terraform-provider-azurerm#23370 `azurerm_resource_deployment_script_azure_power_shell` - improve validation for the `version` property to support newer versions ([#23370](hashicorp/terraform-provider-azurerm#23370 `azurerm_nginx_deployment` - support for the `capacity` and `email` properties ([#23596](https://github.com/hashicorp/terraform-provider-azurerm/issues/23596))

BUG FIXES:

* Data Source: `azurerm_virtual_hub_connection` - export the `inbound_route_map_id`, `outbound_route_map_id`, and `static_vnet_local_route_override_criteria` attributes in the `routing` block, and fix a bug where these attributes could not be set ([#23491](hashicorp/terraform-provider-azurerm#23491 `azurerm_cdn_frontdoor_rule` - the `url_filename_condition` properties `match_values` is now optional if `operator` is set to `Any` ([#23541](hashicorp/terraform-provider-azurerm#23541 `azurerm_shared_image_gallery` - added the `Private` and `Groups` options for the `sharing.permission` property ([#23570](hashicorp/terraform-provider-azurerm#23570 `azurerm_redis_cache` - fixed incorrect ssl values for `redis_primary_connection_string` and `secondary_connection_string` ([#23575](hashicorp/terraform-provider-azurerm#23575 `azurerm_monitor_activity_log_alert` - the `recommend_category` property now can be set to `HighAvailability` ([#23605](hashicorp/terraform-provider-azurerm#23605 `azurerm_recovery_services_vault` - the `encryption` property can now be used with the `cross_region_restore_enabled` property ([#23618](hashicorp/terraform-provider-azurerm#23618 `azurerm_storage_account_customer_managed_key` - prevent a panic when the keyvault id is empty ([#23599](https://github.com/hashicorp/terraform-provider-azurerm/issues/23599))


</pre> </details> </details> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-05-11T02:04:53Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation service/service-networking labels Sep 28, 2023

ziyeqf changed the title ~~New Resource: `~~ New Resource: azurerm_application_load_balancer_frontend Sep 28, 2023

github-actions bot added the size/XL label Sep 28, 2023

tombuildsstuff suggested changes Oct 2, 2023

View reviewed changes

ziyeqf added 2 commits October 12, 2023 10:30

New Resource: azurerm_application_load_balancer_frontend

e9eb2b5

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

update per comments

1f46606

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

ziyeqf force-pushed the tengzh/alb/frontend branch from 82d0ba4 to 1f46606 Compare October 12, 2023 02:31

file renaming

f95d93d

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

github-actions bot added the waiting-response label Oct 12, 2023

github-actions bot added waiting-response and removed waiting-response labels Oct 12, 2023

re-trigger ci

f835372

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

github-actions bot removed the waiting-response label Oct 13, 2023

ziyeqf requested a review from tombuildsstuff October 16, 2023 02:35

catriona-m requested changes Oct 19, 2023

View reviewed changes

internal/services/servicenetworking/application_load_balancer_frontend_resource.go Outdated Show resolved Hide resolved

internal/services/servicenetworking/application_load_balancer_frontend_resource.go Outdated Show resolved Hide resolved

github-actions bot added the waiting-response label Oct 19, 2023

katbyte and others added 2 commits October 19, 2023 08:32

Update internal/services/servicenetworking/application_load_balancer_…

14f5db1

…frontend_resource.go Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>

Update internal/services/servicenetworking/application_load_balancer_…

a04bb37

…frontend_resource.go Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>

github-actions bot removed the waiting-response label Oct 19, 2023

katbyte approved these changes Oct 20, 2023

View reviewed changes

katbyte added 6 commits October 19, 2023 19:46

Update internal/services/servicenetworking/application_load_balancer_…

e987cd0

…frontend_resource.go

Update internal/services/servicenetworking/application_load_balancer_…

58a4265

…frontend_resource.go

Update internal/services/servicenetworking/application_load_balancer_…

867e209

…frontend_resource.go

Update internal/services/servicenetworking/application_load_balancer_…

0dc62a3

…frontend_resource.go

Update internal/services/servicenetworking/application_load_balancer_…

c809954

…frontend_resource_test.go

Update internal/services/servicenetworking/application_load_balancer_…

7a2523a

…frontend_resource_test.go

Update internal/services/servicenetworking/application_load_balancer_…

b64ea4b

…resource.go

katbyte merged commit 1e7cba6 into hashicorp:main Oct 20, 2023
22 checks passed

github-actions bot added this to the v3.77.0 milestone Oct 20, 2023

katbyte added a commit that referenced this pull request Oct 20, 2023

Update CHANGELOG.md #23411

037536f

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_application_load_balancer_frontend` #23411

New Resource: `azurerm_application_load_balancer_frontend` #23411

ziyeqf commented Sep 28, 2023

tombuildsstuff left a comment

ziyeqf commented Oct 12, 2023 •

edited

Loading

catriona-m left a comment

katbyte left a comment

katbyte left a comment

katbyte left a comment

github-actions bot commented May 11, 2024

New Resource: azurerm_application_load_balancer_frontend #23411

New Resource: azurerm_application_load_balancer_frontend #23411

Conversation

ziyeqf commented Sep 28, 2023

test

tombuildsstuff left a comment

Choose a reason for hiding this comment

ziyeqf commented Oct 12, 2023 • edited Loading

new test

catriona-m left a comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented May 11, 2024

New Resource: `azurerm_application_load_balancer_frontend` #23411

New Resource: `azurerm_application_load_balancer_frontend` #23411

ziyeqf commented Oct 12, 2023 •

edited

Loading