Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating vendor dependency/API version for "policy" #2386

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Updating vendor dependency/API version for "policy" #2386

merged 1 commit into from
Nov 26, 2018

Conversation

fayusohenson
Copy link
Contributor

Needed in order to support "deployIfNotExists" effect on custom policy definitions.

Before change:

* azurerm_policy_definition.policy2: 1 error(s) occurred:

* azurerm_policy_definition.policy2: policy.DefinitionsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InvalidPolicyRuleEffect" Message="The policy definition '*****' rule is invalid. The policy 'effect' property value cannot be 'deployIfNotExists'."

After change:

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

…order to support deployIfNotExists custom policies
@ghost ghost added the size/XXL label Nov 26, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fayusohenson,

Thank you for the contribution, LGTM 👍

@katbyte
Copy link
Collaborator

katbyte commented Nov 26, 2018

Tests pass:

screen shot 2018-11-26 at 10 22 54

@katbyte katbyte added this to the 1.20.0 milestone Nov 26, 2018
@katbyte katbyte merged commit ce5cdb9 into hashicorp:master Nov 26, 2018
katbyte added a commit that referenced this pull request Nov 26, 2018
@fayusohenson fayusohenson deleted the policy-api-update-deployIfNotExists branch November 30, 2018 06:13
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants