bugfix: resolve issue with no-deadline context when listing RPs #24056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
force-pushed
the
auth/use-azure-cli-caching
branch
from
a53659a
to
c97aefc
Compare
manicminer
force-pushed
the
auth/use-azure-cli-caching
branch
from
c97aefc
to
da00dc3
Compare
manicminer
changed the title
tombuildsstuff
approved these changes
Nov 30, 2023
| @@ -167,8 +168,11 @@ func Build(ctx context.Context, builder ClientBuilder) (*Client, error) { | |||
| if features.EnhancedValidationEnabled() { | |||
| subscriptionId := commonids.NewSubscriptionID(client.Account.SubscriptionId) | |||
|
|
|||
| location.CacheSupportedLocations(ctx, *resourceManagerEndpoint) | |||
| if err := resourceproviders.CacheSupportedProviders(ctx, client.Resource.ResourceProvidersClient, subscriptionId); err != nil { | |||
| ctx2, cancel := context.WithTimeout(ctx, 10*time.Minute) | |||
There was a problem hiding this comment.
an aside: we should probably think about surfacing the available Locations on the Environment, so that we don't need to hit this endpoint twice?
There was a problem hiding this comment.
good idea, will have a think about it 👍
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug with listing RPs, and also tidy up the auth guides to remove German cloud references.