Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requiring Import (PR 1 of ...) #2511

Merged
merged 18 commits into from
Dec 14, 2018
Merged

Requiring Import (PR 1 of ...) #2511

merged 18 commits into from
Dec 14, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Whilst the Requiring Import change can be feature-toggled; unfortunately the Timeouts change can't - as such we're going to roll out Requiring Import and Timeouts separately.

This is feature-toggled off by default, but can be enabled by an Environment Variable for testing (which we'll enable in 2.0)

Supersedes #1746

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte
Copy link
Collaborator

katbyte commented Dec 13, 2018

(aside from linting error)

@tombuildsstuff
Copy link
Contributor Author

Given this is feature toggled off (and this is a low-risk change across multiple resources) we'll handle the test output for this via the nightly acceptance tests

@tombuildsstuff tombuildsstuff merged commit 6f61fb3 into master Dec 14, 2018
@tombuildsstuff tombuildsstuff deleted the f/requiring-import branch December 14, 2018 10:53
@pixelicous
Copy link

@tombuildsstuff @katbyte so this is going to be implemented only on terraform 2.0 with provider 1.21? if you use this feature toggle it means you will need to set timeouts for all resources from there on out?

thanks in advance

@tombuildsstuff
Copy link
Contributor Author

@pixelicous there's two bits which have been split out from the other PR here: requiring resources to be imported when they already exist (which is what's partially covered in this PR an is feature-toggled off for the moment); the other is the custom timeouts, which isn't covered in this PR and I'm unsure if we can feature-toggle; but in either case both of those features will land in version 2.0 of the AzureRM Provider (the version of Terraform Core is unrelated) :)

@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants