Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exclusions (notScopes) in azurerm_policy_assignment #2620

Merged

Conversation

olohmann
Copy link
Contributor

@olohmann olohmann commented Jan 8, 2019

This PR adds support for exlcusions (notScopes) in Azure Policy Assignments (resource azurerm_policy_set_definition).

Addresses issue #1138

Test Results:

> $ make testacc TESTARGS='-run=TestAccAzureRMPolicyAssignment'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAzureRMPolicyAssignment -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?   	github.com/terraform-providers/terraform-provider-azurerm	[no test files]
=== RUN   TestAccAzureRMPolicyAssignment_basic
=== PAUSE TestAccAzureRMPolicyAssignment_basic
=== RUN   TestAccAzureRMPolicyAssignment_deployIfNotExists_policy
=== PAUSE TestAccAzureRMPolicyAssignment_deployIfNotExists_policy
=== RUN   TestAccAzureRMPolicyAssignment_complete
=== PAUSE TestAccAzureRMPolicyAssignment_complete
=== RUN   TestAccAzureRMPolicyAssignment_not_scopes
=== PAUSE TestAccAzureRMPolicyAssignment_not_scopes
=== CONT  TestAccAzureRMPolicyAssignment_basic
=== CONT  TestAccAzureRMPolicyAssignment_not_scopes
=== CONT  TestAccAzureRMPolicyAssignment_complete
=== CONT  TestAccAzureRMPolicyAssignment_deployIfNotExists_policy
--- PASS: TestAccAzureRMPolicyAssignment_basic (247.49s)
--- PASS: TestAccAzureRMPolicyAssignment_complete (247.53s)
--- PASS: TestAccAzureRMPolicyAssignment_not_scopes (249.56s)
--- PASS: TestAccAzureRMPolicyAssignment_deployIfNotExists_policy (250.12s)

(fixed #1138)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olohmann,

Thank you for the PR, aside from one minor comment i've left in this LGTM 🚀 Hope you don't mind but i am going to fix it now so i can merge 🙂

"not_scopes": {
Type: schema.TypeList,
Optional: true,
ForceNew: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just leave this out if ForceNew is false.

Suggested change
ForceNew: false,

@katbyte katbyte self-assigned this Jan 9, 2019
@katbyte katbyte added this to the 1.21.0 milestone Jan 9, 2019
@katbyte katbyte merged commit 08efda0 into hashicorp:master Jan 9, 2019
katbyte added a commit that referenced this pull request Jan 9, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: azurerm_policy_assignment - add support for setting Exclusions
2 participants