Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: updating hashicorp/go-azure-sdk to v0.20240604.1114748 #26216

Merged

Conversation

hc-github-team-tf-azure
Copy link
Collaborator

This PR updates hashicorp/go-azure-sdk to v0.20240604.1114748 - further details can be found in a comment.

hc-github-team-tf-azure added 2 commits June 4, 2024 11:49
@joshk0
Copy link

joshk0 commented Jun 4, 2024

This should do it:

diff --git a/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_availability_set_resource.go b/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_availability_set_resource.go
index 262befa937..9fee9acc0f 100644
--- a/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_availability_set_resource.go
+++ b/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_availability_set_resource.go
@@ -107,7 +107,7 @@ func (r SystemCenterVirtualMachineManagerAvailabilitySetResource) Create() sdk.R
 					Type: utils.String("customLocation"),
 					Name: utils.String(model.CustomLocationId),
 				},
-				Properties: availabilitysets.AvailabilitySetProperties{
+				Properties: &availabilitysets.AvailabilitySetProperties{
 					AvailabilitySetName: utils.String(id.AvailabilitySetName),
 					VMmServerId:         utils.String(scvmmServerId.ID()),
 				},
@@ -179,7 +179,7 @@ func (r SystemCenterVirtualMachineManagerAvailabilitySetResource) Update() sdk.R
 				return fmt.Errorf("decoding: %+v", err)
 			}
 
-			parameters := availabilitysets.ResourcePatch{}
+			parameters := availabilitysets.AvailabilitySetTagsUpdate{}
 
 			if metadata.ResourceData.HasChange("tags") {
 				parameters.Tags = pointer.To(model.Tags)
@@ -205,7 +205,7 @@ func (r SystemCenterVirtualMachineManagerAvailabilitySetResource) Delete() sdk.R
 				return err
 			}
 
-			if err := client.DeleteThenPoll(ctx, *id, availabilitysets.DeleteOperationOptions{Force: pointer.To(availabilitysets.ForceTrue)}); err != nil {
+			if err := client.DeleteThenPoll(ctx, *id, availabilitysets.DeleteOperationOptions{Force: pointer.To(availabilitysets.ForceDeleteTrue)}); err != nil {
 				return fmt.Errorf("deleting %s: %+v", *id, err)
 			}
 
diff --git a/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go b/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go
index 742133c1ef..76ef31826a 100644
--- a/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go
+++ b/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go
@@ -98,7 +98,7 @@ func (l SystemCenterVirtualMachineManagerInventoryItemsDataSource) Read() sdk.Re
 				return err
 			}
 
-			resp, err := client.ListByVMMServer(ctx, *scvmmServerId)
+			resp, err := client.ListByVMmServer(ctx, *scvmmServerId)
 			if err != nil {
 				if response.WasNotFound(resp.HttpResponse) {
 					return fmt.Errorf("%s was not found", scvmmServerId)
diff --git a/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_server_resource.go b/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_server_resource.go
index 9c57f2d7c1..532b64ac7f 100644
--- a/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_server_resource.go
+++ b/internal/services/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_server_resource.go
@@ -125,14 +125,14 @@ func (r SystemCenterVirtualMachineManagerServerResource) Create() sdk.ResourceFu
 				return metadata.ResourceRequiresImport(r.ResourceType(), id)
 			}
 
-			parameters := &vmmservers.VMMServer{
+			parameters := &vmmservers.VMmServer{
 				Location: location.Normalize(model.Location),
 				ExtendedLocation: vmmservers.ExtendedLocation{
 					Type: pointer.To("customLocation"),
 					Name: pointer.To(model.CustomLocationId),
 				},
-				Properties: vmmservers.VMMServerProperties{
-					Credentials: &vmmservers.VMMCredential{
+				Properties: &vmmservers.VMmServerProperties{
+					Credentials: &vmmservers.VMmCredential{
 						Username: pointer.To(model.Username),
 						Password: pointer.To(model.Password),
 					},
@@ -212,7 +212,7 @@ func (r SystemCenterVirtualMachineManagerServerResource) Update() sdk.ResourceFu
 				return fmt.Errorf("decoding: %+v", err)
 			}
 
-			parameters := vmmservers.ResourcePatch{
+			parameters := vmmservers.VMmServerTagsUpdate{
 				Tags: pointer.To(model.Tags),
 			}
 
@@ -236,7 +236,7 @@ func (r SystemCenterVirtualMachineManagerServerResource) Delete() sdk.ResourceFu
 				return err
 			}
 
-			if err := client.DeleteThenPoll(ctx, *id, vmmservers.DeleteOperationOptions{Force: pointer.To(vmmservers.ForceTrue)}); err != nil {
+			if err := client.DeleteThenPoll(ctx, *id, vmmservers.DeleteOperationOptions{Force: pointer.To(vmmservers.ForceDeleteTrue)}); err != nil {
 				return fmt.Errorf("deleting %s: %+v", *id, err)
 			}
 

@tombuildsstuff
Copy link
Contributor

The automation/check failure is expected, since it can't reopen the same PR - ignoring that

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit to fix the breakages but otherwise 👍

@tombuildsstuff tombuildsstuff added this to the v3.107.0 milestone Jun 4, 2024
@tombuildsstuff tombuildsstuff merged commit c2b526d into main Jun 4, 2024
30 of 31 checks passed
@tombuildsstuff tombuildsstuff deleted the auto-deps-pr/updating-go-azure-sdk-to-v0.20240604.1114748 branch June 4, 2024 16:50
tombuildsstuff added a commit that referenced this pull request Jun 4, 2024
dduportal added a commit to jenkins-infra/azure that referenced this pull request Jun 11, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.104.2&#34; to &#34;3.107.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.107.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.107.0&#xA;FEATURES:&#xA;&#xA;*
**New Resource:**
`azurerm_data_protection_backup_policy_postgresql_flexible_server`
([#26024](https://github.com/hashicorp/terraform-provider-azurerm/issues/26024))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20240604.1114748` of
`github.com/hashicorp/go-azure-sdk`
([#26216](hashicorp/terraform-provider-azurerm#26216
`advisor`: update API version to `2023-01-01`
([#26205](hashicorp/terraform-provider-azurerm#26205
`keyvault`: handling the Resources API returning Key Vaults that have
been deleted when populating the cache
([#26199](hashicorp/terraform-provider-azurerm#26199
`machinelearning`: update API version to `2024-04-01`
([#26168](hashicorp/terraform-provider-azurerm#26168
`network/privatelinkservices` - update to use `hashicorp/go-azure-sdk`
([#26212](hashicorp/terraform-provider-azurerm#26212
`network/serviceendpointpolicies` - update to use
`hashicorp/go-azure-sdk`
([#26196](hashicorp/terraform-provider-azurerm#26196
`network/virtualnetworks` - update to use `hashicorp/go-azure-sdk`
([#26217](hashicorp/terraform-provider-azurerm#26217
`network/virtualwans`: update route resources to use
`hashicorp/go-azure-sdk`
([#26189](hashicorp/terraform-provider-azurerm#26189
`azurerm_container_app_job` - support for the `key_vault_secret_id` and
`identity` properties in the `secret` block
([#25969](hashicorp/terraform-provider-azurerm#25969
`azurerm_kubernetes_cluster` - support forthe `dns_zone_ids` popperty in
the `web_app_routing` block
([#26117](hashicorp/terraform-provider-azurerm#26117
`azurerm_notification_hub_authorization_rule` - support for the
`primary_connection_string` and `secondary_connection_string` properties
([#26188](hashicorp/terraform-provider-azurerm#26188
`azurerm_subnet` - support for the `default_outbound_access_enabled`
property
([#25259](https://github.com/hashicorp/terraform-provider-azurerm/issues/25259))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_api_management_named_value` - will now
enforce setting the `secret` property when setting the
`value_from_key_vault` property
([#26150](hashicorp/terraform-provider-azurerm#26150
`azurerm_storage_sync_server_endpoint` - improve pooling to work around
api inconsistencies
([#26204](hashicorp/terraform-provider-azurerm#26204
`azurerm_virtual_network` - split create and update function to fix
lifecycle - ignore
([#26246](hashicorp/terraform-provider-azurerm#26246
`azurerm_vpn_server_configuration` - split create and update function to
fix lifecycle - ignore
([#26175](hashicorp/terraform-provider-azurerm#26175
`azurerm_vpn_server_configuration_policy_group` - split create and
update function to fix lifecycle - ignore
([#26207](hashicorp/terraform-provider-azurerm#26207
`azurerm_vpn_site` - split create and update function to fix lifecycle -
ignore changes
([#26163](https://github.com/hashicorp/terraform-provider-azurerm/issues/26163))&#xA;&#xA;DEPRECATIONS:&#xA;&#xA;*
`azurerm_kubernetes_cluster` - the property `dns_zone_id` has been
superseded by the property `dns_zone_ids` in the `web_app_routing` block
([#26117](hashicorp/terraform-provider-azurerm#26117
`azurerm_nginx_deployment` - the block `configuration` has been
deprecated and superseded by the resource `azurerm_nginx_configuration`
([#25773](https://github.com/hashicorp/terraform-provider-azurerm/issues/25773))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/229/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

---------

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Copy link

github-actions bot commented Jul 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants