Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serviceconnector: Upgrade service connector SDK version to 2024-04-01 #26248

Merged
merged 2 commits into from
Jun 12, 2024
Merged

serviceconnector: Upgrade service connector SDK version to 2024-04-01 #26248

merged 2 commits into from
Jun 12, 2024

Conversation

jiaweitao001
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • serviceconnector: Upgrade service connector SDK version to 2024-04-01

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@jiaweitao001 jiaweitao001 force-pushed the upgrade_serviceconnector_version branch from 01622e4 to dc08ce7 Compare June 6, 2024 05:55
@jiaweitao001 jiaweitao001 marked this pull request as ready for review June 6, 2024 06:06
tombuildsstuff
tombuildsstuff approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2024-06-12 at 16 31 45

@tombuildsstuff tombuildsstuff added this to the v3.108.0 milestone Jun 12, 2024
@tombuildsstuff tombuildsstuff merged commit 62d8694 into hashicorp:main Jun 12, 2024
30 checks passed
tombuildsstuff added a commit that referenced this pull request Jun 12, 2024
@tombuildsstuff
updating to include #26248
e394159
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jun 18, 2024
@jenkins-infra-updatecli @jenkins-infra-bot
Bump Terraform azurerm provider version to 3.108.0 (#728)
eb8a25e 
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.107.0&#34; to &#34;3.108.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.108.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.108.0&#xA;FEATURES:&#xA;&#xA;*
**New Data Source:** `azurerm_role_management_policy`
([#25900](hashicorp/terraform-provider-azurerm#25900
**New Resource:** `azurerm_role_management_policy`
([#25900](https://github.com/hashicorp/terraform-provider-azurerm/issues/25900))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
provider: support subscription ID hinting when using Azure CLI
authentication
([#26282](hashicorp/terraform-provider-azurerm#26282
`serviceconnector`: updating to use API Version `2024-04-01`
([#26248](hashicorp/terraform-provider-azurerm#26248
`azurerm_container_groups` - can now be created with a User Assigned
Identity when running Windows
([#26308](hashicorp/terraform-provider-azurerm#26308
`azurerm_kubernetes_cluster` - updating the
`network_profile.network_policy` property to `azure` and `calico` when
it hasn&#39;t been previously set is supported
([#26176](hashicorp/terraform-provider-azurerm#26176
`azurerm_kubernetes_cluster` - respect Pod Distruption Budgets when
rotating the `default_node_pool`
([#26274](hashicorp/terraform-provider-azurerm#26274
`azurerm_lb_backend_address_pool` - support for the `synchronous_mode`
property
([#26309](hashicorp/terraform-provider-azurerm#26309
`azurerm_private_endpoint` - support symultaneous creation of multiple
resources of this type per subnet
([#26006](https://github.com/hashicorp/terraform-provider-azurerm/issues/26006))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_express_route_circuit_peering`,
`azurerm_express_route_circuit`, `azurerm_express_route_gateway`,
`azurerm_express_route_port` - split create and update
([#26237](hashicorp/terraform-provider-azurerm#26237
`azurerm_lb_backend_address_pool_address` - when using this resource,
values are no longer reset on `azurerm_lb_backend_address_pool`
([#26264](hashicorp/terraform-provider-azurerm#26264
`azurerm_route_filter` - spliting create and update so lifecycle ignore
changes works correctly
([#26266](hashicorp/terraform-provider-azurerm#26266
`azurerm_route_server` - spliting create and update so lifecycle ignore
changes works correctly
([#26266](hashicorp/terraform-provider-azurerm#26266
`azurerm_synapse_workspace` - updates the client used in all operations
of `azurerm_synapse_workspace_sql_aad_admin` to prevent this resource
from modifying the same resource as
`azurerm_synapse_workspace_aad_admin`
([#26317](hashicorp/terraform-provider-azurerm#26317
`azurerm_virtual_network` - correctly parse network securty group IDs
([#26283](https://github.com/hashicorp/terraform-provider-azurerm/issues/26283))&#xA;&#xA;DEPRECATIONS:&#xA;&#xA;*
Data Source: `azurerm_network_interface` - the `enable_ip_forwarding`
and `enable_accelerated_networking` properties have been deprecated and
superseded by the `ip_forwarding_enabled` and
`accelerated_networking_enabled` properties
([#26293](hashicorp/terraform-provider-azurerm#26293
`azurerm_api_management` - the `policy` block has been deprecated is
superseded by the `azurerm_api_management_policy` resource
([#26305](hashicorp/terraform-provider-azurerm#26305
`azurerm_kubernetes_cluster` - the `ebpf_data_plane` property has been
deprecated and superseded by the `network_data_plane` property
([#26251](hashicorp/terraform-provider-azurerm#26251
`azurerm_network_interface` - the `enable_ip_forwarding` and
`enable_accelerated_networking` properties have been deprecated and
superseded by the `ip_forwarding_enabled` and
`accelerated_networking_enabled` properties
([#26293](hashicorp/terraform-provider-azurerm#26293
`azurerm_synapse_workspace` - the `aad_admin` and `sql_aad_admin` blocks
have been deprecated and superseded by the
`azurerm_synapse_workspace_aad_admin` and
`azurerm_synapse_workspace_sql_aad_admin` resources
([#26317](https://github.com/hashicorp/terraform-provider-azurerm/issues/26317))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/244/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
@donjuanmon donjuanmon mentioned this pull request Jul 5, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies service/service-connector size/XL
Projects
None yet
Milestone
v3.108.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jiaweitao001 @tombuildsstuff