Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource azurerm_api_management add V2 SKUs #26770

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ZsoltPath
Copy link

@ZsoltPath ZsoltPath commented Jul 24, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Adds BasicV2 and StandardV2 SKUs to azurerm_api_management resource
The new SKUs are generally available. https://azure.microsoft.com/en-us/pricing/details/api-management/

Unfortunately it breaks the sign_in and sign_up optional Developer portal settings.
I think they'll need one or two new resources to configure them separately. They aren't part of this PR.
The APIM resource is installing and working without them.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
    I couldn't run the acceptance test. I only have access to a very restricted subscription. It has a rule for RG names. I changed all of them in the tests, but then all of them failed because the subscription has an automatic deletion lock on all RGs.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_api_management - support for the BasicV2 and StandardV2 values in the sku_name property

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #25445

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@chrisyaxley
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for New SKU Tiers in Azure API Management
3 participants