-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource azurerm_api_management add V2 SKUs #26770
Open
ZsoltPath
wants to merge
10
commits into
hashicorp:main
Choose a base branch
from
rbs-path:api-management-add-v2-skus
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+22,230
−2,241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
Adds BasicV2 and StandardV2 SKUs to
azurerm_api_management
resourceThe new SKUs are generally available. https://azure.microsoft.com/en-us/pricing/details/api-management/
Unfortunately it breaks the
sign_in
andsign_up
optional Developer portal settings.I think they'll need one or two new resources to configure them separately. They aren't part of this PR.
The APIM resource is installing and working without them.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
I couldn't run the acceptance test. I only have access to a very restricted subscription. It has a rule for RG names. I changed all of them in the tests, but then all of them failed because the subscription has an automatic deletion lock on all RGs.
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_api_management
- support for theBasicV2
andStandardV2
values in thesku_name
propertyThis is a (please select all that apply):
Related Issue(s)
Fixes #25445
Note
If this PR changes meaningfully during the course of review please update the title and description as required.