Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: mssql_elasticpool max_size_bytes to max_size_gb #2695

Merged
merged 46 commits into from
Feb 5, 2019
Merged

Refactor: mssql_elasticpool max_size_bytes to max_size_gb #2695

merged 46 commits into from
Feb 5, 2019

Commits on Jan 16, 2019

  1. WIP: Initial check-in for max_size_gb

    @WodansSon
    WodansSon committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    6c4a9c0 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Finished adding validation for Elasticpool max_size_gb

    @WodansSon
    WodansSon committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    e6a2bd3 View commit details
    Browse the repository at this point in the history

  2. Added additional SKU check and updated docs

    @WodansSon
    WodansSon committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    615fd79 View commit details
    Browse the repository at this point in the history

  3. Updated tests to use max_size_gb

    @WodansSon
    WodansSon committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    8fcfb4a View commit details
    Browse the repository at this point in the history

  4. fix lint errors

    @WodansSon
    WodansSon committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    6ba0752 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. Added additional Standard and Premium size check

    @WodansSon
    WodansSon committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    3ccc0b4 View commit details
    Browse the repository at this point in the history

  2. Switched logic to use maps instead

    @WodansSon
    WodansSon committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    706e7a7 View commit details
    Browse the repository at this point in the history

  3. Added values to error msgs

    @WodansSon
    WodansSon committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    541ee9e View commit details
    Browse the repository at this point in the history

  4. fix format casing

    @WodansSon
    WodansSon committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    92cd03a View commit details
    Browse the repository at this point in the history

  5. Addressed PR comments and updated some func names

    @WodansSon
    WodansSon committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    8289782 View commit details
    Browse the repository at this point in the history

  6. Fixed lint errors and remove helper function

    @WodansSon
    WodansSon committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    028c5b1 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. Fixed test issue

    @WodansSon
    WodansSon committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    ee38137 View commit details
    Browse the repository at this point in the history

  2. Had to special case Basic tier for setting max_size_gb

    @WodansSon
    WodansSon committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    9635e5c View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. Added Name Tier combo validation

    @WodansSon
    WodansSon committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    4b2a43f View commit details
    Browse the repository at this point in the history

  2. Updated to auto-fill tier based of name attribute

    @WodansSon
    WodansSon committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    9b5352e View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Added auto-fill attributes for Tier and Family

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    0b5dd6d View commit details
    Browse the repository at this point in the history

  2. Added Test cases for DTU and vCore autofill

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    8a86194 View commit details
    Browse the repository at this point in the history

  3. Update for lint errors

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    2c4cb79 View commit details
    Browse the repository at this point in the history

  4. Update tests

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    a589be8 View commit details
    Browse the repository at this point in the history

  5. Fixed test cases

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    41f04b5 View commit details
    Browse the repository at this point in the history

  6. Fix Lint error

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    0507be0 View commit details
    Browse the repository at this point in the history

  7. Updated GetOkExists to GetOk

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    08522c4 View commit details
    Browse the repository at this point in the history

  8. Revert Auto-fill functionality

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    70d8638 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into refactor-elasticpool-maxsize

    @WodansSon
    WodansSon authored Jan 25, 2019
    Configuration menu
    Copy the full SHA
    807aa42 View commit details
    Browse the repository at this point in the history

  10. Fixing up after merge from master

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    dd7d968 View commit details
    Browse the repository at this point in the history

  11. Fix lint errors

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    eb2f5d2 View commit details
    Browse the repository at this point in the history

  12. Removed commented code

    @WodansSon
    WodansSon committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    faf2c8e View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. Exposed max_size_bytes, updated documentation, and added test case

    @WodansSon
    WodansSon committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    39f4113 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Update azurerm/resource_arm_mssql_elasticpool.go 

    Co-Authored-By: jeffreyCline <jcline@microsoft.com>
    @katbyte @WodansSon
    katbyte and WodansSon authored Jan 30, 2019
    Configuration menu
    Copy the full SHA
    0ab8771 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. Fixes for PR comments

    @WodansSon
    WodansSon committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    f4b805c View commit details
    Browse the repository at this point in the history

  2. Updated GetTierFromSKUName to use map

    @WodansSon
    WodansSon committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    544b19a View commit details
    Browse the repository at this point in the history

  3. Updated error msg for clarity

    @WodansSon
    WodansSon committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    347f83d View commit details
    Browse the repository at this point in the history

  4. Switch to using nested maps

    @WodansSon
    WodansSon committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    3421bff View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Updated errors to be dynamically generated

    @WodansSon
    WodansSon committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    ab9c67a View commit details
    Browse the repository at this point in the history

  2. Added descriptions of maps

    @WodansSon
    WodansSon committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    66ac53b View commit details
    Browse the repository at this point in the history

  3. Unifying func signatures

    @WodansSon
    WodansSon committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    98eb1d3 View commit details
    Browse the repository at this point in the history

  4. Removed unneeded validation check

    @WodansSon
    WodansSon committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    d397373 View commit details
    Browse the repository at this point in the history

  5. Updated name and family validation

    @WodansSon
    WodansSon committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    5994856 View commit details
    Browse the repository at this point in the history

  6. Fixed issue due to code editor auto-complete

    @WodansSon
    WodansSon committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    be8580b View commit details
    Browse the repository at this point in the history

  7. Changed to Errorf

    @WodansSon
    WodansSon committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    2e3809b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2019

  1. Update for edge case

    @WodansSon
    WodansSon committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    6933c4b View commit details
    Browse the repository at this point in the history

  2. Updated map to get better code reuse

    @WodansSon
    WodansSon committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    0bd9ea7 View commit details
    Browse the repository at this point in the history

  3. Missed a space

    @WodansSon
    WodansSon committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    321139f View commit details
    Browse the repository at this point in the history

  4. Fix lint error

    @WodansSon
    WodansSon committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    56ecf29 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. broke doSKUValidation into two seperate functions

    @katbyte
    katbyte committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    857797e View commit details
    Browse the repository at this point in the history

  2. fix linting

    @katbyte
    katbyte committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    9d69371 View commit details
    Browse the repository at this point in the history