-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_linux_function_app
- add flex consumption feature.
#27531
base: main
Are you sure you want to change the base?
Conversation
Very excited for this PR! Please review team :) |
} else { | ||
appSettings = updateOrAppendAppSettings(appSettings, "AzureWebJobsStorage", storageString, false) | ||
if storageString != "" { | ||
appSettings = updateOrAppendAppSettings(appSettings, "FUNCTIONS_EXTENSION_VERSION", version, false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not add this FUNCTIONS_EXTENSION_VERSION app setting for Flex Consumption function apps. It will eventually be blocked for Flex Consumption apps and is not required. The runtime version that this conveyed for other hosting plans is now handled automatically by the platform for Flex Consumption.
Type: pluginsdk.TypeInt, | ||
Optional: true, | ||
Default: 2048, | ||
ValidateFunc: validation.IntInSlice([]int{512, 2048, 4096}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list might not be true for all regions, and we might introduce new instance sizes in the future. The actual list per region comes from the Stacks API but that is dynamic, not sure if we can use it in terraform to validate right? So here we have to decide:
- Do we not validate and let the user put any number (which if they put incorrectly will show a control plane exception)
- Or do we put the current list here of all possible current instance sizes here, and then keep updating the list of values as new instance sizes are introduced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From our perspective, we would rather have new sizes available immediately and a control plane exception kick up, rather than having to wait for the AzureRM team to fix it each time a new size is available. My vote is for option 1 (no validation).
Community Note
Description
Support azure function running in azure flex consumption plan
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource
- support for thething1
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.