Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_function_app - add flex consumption feature. #27531

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Sep 29, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Support azure function running in azure flex consumption plan

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@xiaxyi xiaxyi marked this pull request as draft September 29, 2024 06:39
@xiaxyi xiaxyi marked this pull request as ready for review October 28, 2024 03:09
@xiaxyi xiaxyi requested review from katbyte and a team as code owners October 28, 2024 03:09
@dvasdekis
Copy link

Very excited for this PR! Please review team :)

} else {
appSettings = updateOrAppendAppSettings(appSettings, "AzureWebJobsStorage", storageString, false)
if storageString != "" {
appSettings = updateOrAppendAppSettings(appSettings, "FUNCTIONS_EXTENSION_VERSION", version, false)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add this FUNCTIONS_EXTENSION_VERSION app setting for Flex Consumption function apps. It will eventually be blocked for Flex Consumption apps and is not required. The runtime version that this conveyed for other hosting plans is now handled automatically by the platform for Flex Consumption.

Type: pluginsdk.TypeInt,
Optional: true,
Default: 2048,
ValidateFunc: validation.IntInSlice([]int{512, 2048, 4096}),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list might not be true for all regions, and we might introduce new instance sizes in the future. The actual list per region comes from the Stacks API but that is dynamic, not sure if we can use it in terraform to validate right? So here we have to decide:

  • Do we not validate and let the user put any number (which if they put incorrectly will show a control plane exception)
  • Or do we put the current list here of all possible current instance sizes here, and then keep updating the list of values as new instance sizes are introduced?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our perspective, we would rather have new sizes available immediately and a control plane exception kick up, rather than having to wait for the AzureRM team to fix it each time a new size is available. My vote is for option 1 (no validation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants