Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for auth_settings in app service slot #3659

Closed
wants to merge 6 commits into from
Closed

Support for auth_settings in app service slot #3659

wants to merge 6 commits into from

Conversation

MattiasAng
Copy link
Contributor

No description provided.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @MattiasAng

Thanks for this PR - taking a look through this LGTM 👍

Thanks!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MattiasAng,

Seeing some test failures :

------- Stdout: -------
=== RUN   TestAccAzureRMAppServiceSlot_googleAuthSettings
=== PAUSE TestAccAzureRMAppServiceSlot_googleAuthSettings
=== CONT  TestAccAzureRMAppServiceSlot_googleAuthSettings
--- FAIL: TestAccAzureRMAppServiceSlot_googleAuthSettings (173.89s)
    testing.go:568: Step 0 error: Check failed: Check 2/5 error: azurerm_app_service.test: Attribute 'auth_settings.0.enabled' expected "true", got "false"
FAIL

@MattiasAng
Copy link
Contributor Author

MattiasAng commented Jun 28, 2019

@katbyte My bad, fixed for all tests now.

=== RUN   TestAccAzureRMAppServiceSlot_googleAuthSettings
=== PAUSE TestAccAzureRMAppServiceSlot_googleAuthSettings
=== CONT  TestAccAzureRMAppServiceSlot_googleAuthSettings
--- PASS: TestAccAzureRMAppServiceSlot_googleAuthSettings (221.43s)

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @MattiasAng

Thanks for fixing the tests - this now LGTM; however it requires rebasing for it to be merged; as such I hope you don't mind but I'm going to do this and push a commit.

Thanks!

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Jul 22, 2019

hey @MattiasAng

Thanks again for this PR - unfortunately since this is on your master branch unfortunately I'm unable to rebase this without breaking the PR which means that to rebase this unfortunately I'm going to have to close this PR and open another (which includes all the changes you've made & keeps the attribution). As such I hope you don't mind, but I'm going to close this PR in favour of #3897 - but this should make it into the 1.32 release :)

Thanks!

@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 21, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants