Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring we register the MySQL Resource Provider #397

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Tests pass:

$ acctests azurerm TestAccAzureRMResourceProviderRegistration
=== RUN   TestAccAzureRMResourceProviderRegistration
# ...
--- PASS: TestAccAzureRMResourceProviderRegistration (1.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1.955s

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these tests not passing before? i.e. how did you discover it's not being registered?

@tombuildsstuff
Copy link
Contributor Author

The tests were passing before - but they're verifying that the values in the array are of the correct case - not that resources can be provisioned within that Resource Provider (which is outside the scope of the test).

I noticed it when doing the SDK upgrade - the Resource Provider gets automatically registered a resource is provisioned in the Portal (which we do to confirm the SKU's) - and wasn't added to the list.

@tombuildsstuff tombuildsstuff merged commit 23c42b4 into master Oct 5, 2017
@tombuildsstuff tombuildsstuff deleted the mysql-resource-provider branch October 5, 2017 12:24
tombuildsstuff added a commit that referenced this pull request Oct 5, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants