Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates tags limits from 15 to 50 per resource #4071

Merged

Conversation

Shenderchuk
Copy link
Contributor

The PR fixes an issue described in #4070 where is not possible to apply more than 15 tags for any Azure resource because of hard validation (15 is a maximum in the code). But Azure right now supports 50 tags per resource (except storage account, which has own validation and there is still 15).

reference: https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-group-using-tags

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Shenderchuk

Thanks for this PR - taking a look through this LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff added this to the v1.33.0 milestone Aug 14, 2019
@tombuildsstuff tombuildsstuff merged commit 997e5c3 into hashicorp:master Aug 14, 2019
tombuildsstuff added a commit that referenced this pull request Aug 14, 2019
@ghost
Copy link

ghost commented Aug 22, 2019

This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.33.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants