Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: Front Door Firewall Policy #4125

Merged
merged 85 commits into from
Sep 18, 2019
Merged

Conversation

WodansSon
Copy link
Collaborator

Adding support for Front Door Firewall Policies

[fixes: #3186 ]

@tombuildsstuff tombuildsstuff added this to the v1.35.0 milestone Sep 12, 2019
Type: schema.TypeInt,
Optional: true,
Default: 10,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be validating this?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! only a couple comments left inline

Type: schema.TypeInt,
Optional: true,
Default: 1,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be validating this?

@ghost ghost added size/XXL and removed size/XL labels Sep 17, 2019
@WodansSon WodansSon changed the title [WIP]New Resource: Front Door Firewall Policy New Resource: Front Door Firewall Policy Sep 17, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @jeffreyCline, left some comments inline and as discussed will update the PR & docs shortly

"redirect_url": {
Type: schema.TypeString,
Optional: true,
ValidateFunc: validate.NoEmptyStrings,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we validate this as a url?

azurerm/resource_arm_front_door_firewall_policy.go Outdated Show resolved Hide resolved
website/docs/r/front_door_firewall_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/front_door_firewall_policy.html.markdown Outdated Show resolved Hide resolved
azurerm/resource_arm_front_door_firewall_policy.go Outdated Show resolved Hide resolved
azurerm/resource_arm_front_door_firewall_policy.go Outdated Show resolved Hide resolved
azurerm/resource_arm_front_door_firewall_policy.go Outdated Show resolved Hide resolved
azurerm/resource_arm_front_door_firewall_policy.go Outdated Show resolved Hide resolved
azurerm/resource_arm_front_door_firewall_policy.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @jeffreyCline, LGTM 👍

@katbyte katbyte merged commit 1f32f7a into master Sep 18, 2019
@katbyte katbyte deleted the nr_frontdoor_firewall-policy branch September 18, 2019 00:24
@katbyte katbyte modified the milestones: v1.35.0, v1.34.0 Sep 18, 2019
@WodansSon
Copy link
Collaborator Author

image

katbyte added a commit that referenced this pull request Sep 18, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 18, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Azure Front Door
3 participants