Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring clients: phase 4 #5127

Merged
merged 12 commits into from
Dec 10, 2019
Merged

refactoring clients: phase 4 #5127

merged 12 commits into from
Dec 10, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR is Phase 4 of refactoring Clients into Packages so that we can refactor the Data Sources & Resources required for 2.0

I've also taken the opportunity to rename a couple of the clients to use more consistent naming

@tombuildsstuff tombuildsstuff added this to the v1.39.0 milestone Dec 10, 2019
@ghost ghost added the size/XL label Dec 10, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 80499ee into master Dec 10, 2019
@katbyte katbyte deleted the r/clients-4 branch December 10, 2019 23:25
@ghost
Copy link

ghost commented Dec 16, 2019

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants