r/(linux|windows)_virtual_machine_scale_set - support for Disk Encryption Sets

[ArcturusZhang]

This is part of update of the SSE-CMK feature, adding new fields for azurerm_linux_virtual_machine_scale_set, azurerm_windows_virtual_machine_scale_set.

[tombuildsstuff]

Dependent on #5249

[ArcturusZhang]

Rebase and some changes to conform the changes in Managed Disks

[tombuildsstuff]

[rebased this on top of master]

[tombuildsstuff]

hi @ArcturusZhang

Thanks for this PR - I've taken a look through and left some comments inline but this is off to a good start. As with #5249 and #5250 since this requires rebasing on top of those PR's/master and adding tests I hope you don't mind but I'm going to push some commits to fix up the issues and add the tests so that we can get this merged/shipped 👍

Thanks!

[katbyte]

Aside from a few minor comments LGTM 👍

[tombuildsstuff]

[pushed a couple of commits to fix up breaking behavioural changes to VMSS, unrelated to this PR but helps the tests pass]

[tombuildsstuff]

Ignoring a handful of known/expected test failures - the tests pass:

[ghost]

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!