Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_operation - will no longer panic on missing values in response #5273

Merged
merged 2 commits into from
Dec 30, 2019

Conversation

jackbatzner
Copy link
Contributor

Fix panic in 'azurerm_api_management_operation'

Recreatd #5243 after the changes to the provider organization.

Jack Batzner added 2 commits December 30, 2019 07:07
- Don't return error when mapping cannot occur
- Conditionally assign value for 'header', 'query_parameter', 'representation'
@ghost ghost added the size/XS label Dec 30, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @Brunhil! LGTM 👍

@katbyte katbyte added this to the v1.40.0 milestone Dec 30, 2019
@katbyte katbyte changed the title Fix panic in 'azurerm_api_management_operation' azurerm_api_management_operation - will no longer panic on missing values in response Dec 30, 2019
@katbyte katbyte merged commit c7fa512 into hashicorp:master Dec 30, 2019
katbyte added a commit that referenced this pull request Dec 30, 2019
jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this pull request Dec 31, 2019
Fix panic in 'azurerm_api_management_operation'

Recreatd hashicorp#5243 after the changes to the provider organization.
jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this pull request Dec 31, 2019
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@jackbatzner jackbatzner deleted the apim-op-panic branch March 14, 2020 14:48
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants