Conditional loading of the Subscription ID / Tenant ID / Environment

[tombuildsstuff]

Needs some tests / validation - but seems promising in some initial testing

Fixes #562

[pmarques]

@tombuildsstuff I just read your changes but it seems to be error-prone when someone has multiple subscriptions and multiple tenants (multiple accounts).
If I try to use subscription-A and my default subscription is subscription-B for a different tenant this seems to pick the wrong tenant.

[tombuildsstuff]

@pmarques thanks for the feedback, I wasn't sure that scenario was possible - so I'll update this to take that into account - thanks!

[tombuildsstuff]

@pmarques thanks for the testing suggestions :)

I've gone through and verified these scenarios:

• Specifying a Service Principal through Environment Variables
• Logging into CloudShell with a Single Subscription in a Single Tenant
• Logging into CloudShell with Multiple Subscriptions in a Single Tenant (as shown below)
• Logging into the Azure CLI with a Single Subscription in a Single Tenant
• Logging into the Azure CLI with multiple Subscriptions in the same Tenant - as shown below:

provider "azurerm" {
  alias           = "First"
  subscription_id = "00000000-0000-0000-0000-000000000000"
}

resource "azurerm_resource_group" "first" {
  name     = "tharvey-dev1"
  location = "West Europe"
  provider = "azurerm.First"
}

provider "azurerm" {
  alias = "Second"
}

resource "azurerm_resource_group" "second" {
  name     = "tharvey-dev2"
  location = "West Europe"
  provider = "azurerm.Second"
}

provider "azurerm" {
  alias           = "Third"
  subscription_id = "00000000-0000-0000-0000-000000000000"
  tenant_id       = "00000000-0000-0000-0000-000000000000"
}

resource "azurerm_resource_group" "third" {
  name     = "tharvey-dev3"
  location = "West Europe"
  provider = "azurerm.Third"
}

However I'm unable to test the scenario of using Multiple Subscriptions in different Tenants (since we don't have an account with that configuration).

If you've got access to an account with this configuration and feel comfortable - I'd really appreciate it if you could test this works - the best way to do that would be to check out this branch and build it locally as outlined here. That said - I'm relatively confident that this should work.

Thanks!

[mbfrahry]

LGTM

[bnygld]

I'm still seeing this problem when I specify the Subscription ID in the provider using
Terraform v0.11.2 provider.azurerm v1.1.0

My account has multiple subscriptions and one tenant.

[pmarques]

@benny-gold this is currently working for me, do you still have issues? Was using v0.11.2 and now I'm using v0.11.3, so far so good.

[bnygld]

all good with v.0.11.3 @pmarques thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!