Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-opening PR #755 #762

Merged
merged 2 commits into from
Jan 26, 2018
Merged

Re-opening PR #755 #762

merged 2 commits into from
Jan 26, 2018

Commits on Jan 25, 2018

  1. added missing built-in roles. open issues 670 and 671 will be fixed.

    @aantony2
    aantony2 committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    f796b5d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. Fixing the acceptance tests for the Built In Role Definition Data Source 

    Also adds a couple of TODO's for future refactoring

Tests pass:

```
$ acctests azurerm TestAccDataSourceAzureRMBuiltInRoleDefinition_
=== RUN   TestAccDataSourceAzureRMBuiltInRoleDefinition_contributor
--- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_contributor (12.59s)
=== RUN   TestAccDataSourceAzureRMBuiltInRoleDefinition_owner
--- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_owner (8.40s)
=== RUN   TestAccDataSourceAzureRMBuiltInRoleDefinition_reader
--- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_reader (7.82s)
=== RUN   TestAccDataSourceAzureRMBuiltInRoleDefinition_virtualMachineContributor
--- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_virtualMachineContributor (9.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	38.201s
```
    @tombuildsstuff
    tombuildsstuff committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    3e3495e View commit details
    Browse the repository at this point in the history