Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_public_ip: Adding an acceptance test to check that the ip_address property is set #789

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

tombuildsstuff
Copy link
Contributor

This currently fails against the master branch:

$ acctests azurerm TestAccAzureRMPublicIpStatic_basic
=== RUN   TestAccAzureRMPublicIpStatic_basic
--- FAIL: TestAccAzureRMPublicIpStatic_basic (70.86s)
	testing.go:459: Step 0 error: Check failed: Check 2/3 error: azurerm_public_ip.test: Attribute 'ip_address' expected to be set
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-azurerm/azurerm	70.886s

But will pass once #772 is merged:

$ acctests azurerm TestAccAzureRMPublicIpStatic_basic
=== RUN   TestAccAzureRMPublicIpStatic_basic
--- PASS: TestAccAzureRMPublicIpStatic_basic (83.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	83.219s

…property is set

This currently fails against the `master` branch:

```
$ acctests azurerm TestAccAzureRMPublicIpStatic_basic
=== RUN   TestAccAzureRMPublicIpStatic_basic
--- FAIL: TestAccAzureRMPublicIpStatic_basic (70.86s)
	testing.go:459: Step 0 error: Check failed: Check 2/3 error: azurerm_public_ip.test: Attribute 'ip_address' expected to be set
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-azurerm/azurerm	70.886s
```

But will pass once #772 is merged:

```
$ acctests azurerm TestAccAzureRMPublicIpStatic_basic
=== RUN   TestAccAzureRMPublicIpStatic_basic
--- PASS: TestAccAzureRMPublicIpStatic_basic (83.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	83.219s
```
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 514af66 into master Feb 5, 2018
@tombuildsstuff tombuildsstuff deleted the public-ip-acctest branch February 5, 2018 13:34
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants