[WIP] New Resource: azurerm_app_service_environment

[tombuildsstuff]

Note: This resource takes 1.5 up to 30 hours to provision - which makes this challenging to develop.

Opening this to keep track of things - this resource is still under heavy development and will change.

Due to the size of the resource we're focused on Required fields first, and additional Optional fields can be added later.

To Do

• Resource Implementation
  • Create
  • Update
  • Read
  • Delete
  • Verify the Schema design is correct
  • Resource Timeouts
  • Add Validation
• Tests
  • Acceptance Tests
  • Import Tests
  • Acceptance test for an App Service Plan within an App Service Environment (introduced in App Service Plan: support for attaching to an App Service Environment #850)
• Add a Data Source
• Documentation (incl. "this takes 3-30h+ to provision" notice)

Fixes #438

[tombuildsstuff]

From the testing I've been doing here, it might be worth focusing on ASEv2 for the moment, rather than trying to support both v1 and v2 🤔

[Phydeauxman]

Do you at least have it to a point where your session does not time out before the resource finishes deploying? That is the issue I have been having when trying to deploy using an ARM template resource in my TF config.

[tombuildsstuff]

@Phydeauxman unfortunately not, the tests for ASEv1 have been timing out after 30 hours - so I've pushed a change to try running these against ASEv2, and the tests are running atm.

There's a separate fix coming for #937 in the next release or so (unfortunately we missed that bug when upgrading to the latest upgrade to the Azure SDK, since our Template Deployment tests don't take an extended period; although we'll definitely be adding one as part of the fix).

[bajorgensen]

Thumbs up for focusing on v2 for now. While v1 has a different price plan, the benefits of v2 outweighs the potential price savings for v1.
I cannot see anyone deploying v2 going forward.
Keep focusing on getting basic v2 functionality in place!

[bajorgensen]

Depending on #1085 or #1077?
Give us a heads up when it is resolved, we could help QA development.

[tombuildsstuff]

@bajorgensen this is a bug in the Azure API (rather than the SDK), so neither of those PR's will have fixed it unfortunately. We've raised this through some internal channels, but we can't proceed with this until that's fixed, unfortunately.

[nycjay01]

Hi I'm looking to try ASE with terraform. Is this complete?

[tombuildsstuff]

@nycjay01 not at this time, we're waiting on the API team to confirm the status of the API unfortunately (since we're seeing provisioning timeouts after 30 hours)

[nycjay01]

Cool thnx.. Hope its soon just lost a project to ARM Templates because of this :-) Thanks for your repo lots of good stuff!

…

On Thu, May 31, 2018 at 3:04 AM, Tom Harvey ***@***.***> wrote: @nycjay01 <https://github.com/nycjay01> not at this time, we're waiting on the API team to confirm the status of the API unfortunately (since we're seeing provisioning timeouts after 30 hours) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#869 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVfFlt6JkESIcZfp3Y6TIqezxb4VXSH8ks5t38A1gaJpZM4SNCeZ> .

-- Thank You, John Beltrez 646 824 5828

[tombuildsstuff]

@nycjay01 on that note - it's possible to use ARM Templates within Terraform via the azurerm_template_deployment resource to deploy this resource in the interim threading Parameters in both directions (e.g. create the Resource Group with native Terraform, then just create the App Service Environment in an ARM Template; then create the App Service Plan with native Terraform) :)

[Phydeauxman]

@tombuildsstuff was the issue of App Service Plan returning an undocumented success code ever resolved? Would love to switch my App Service Plan over to native Terraform from an ARM resource

[tombuildsstuff]

@tombuildsstuff was the issue of App Service Plan returning an undocumented success code ever resolved? Would love to switch my App Service Plan over to native Terraform from an ARM resource

@Phydeauxman that's being tracked in #917 which will apparently be fixed by v17 of the Azure SDK for Go - I've taken a quick look into that today and we'll be holding off for the moment (I believe [but haven't yet confirmed] that there's a regression in one of the dependencies). Whilst I appreciate it's frustrating - my understanding is that the next SDK upgrade should fix this :)

[Phydeauxman]

@tombuildsstuff thanks for the update

[rifaterdemsahin]

any examples for this use case ?

[tombuildsstuff]

@rifaterdemsahin not at this time - we're still waiting for the API to be fixed to be able to look into supporting App Service Environments unfortunately.

[tombuildsstuff]

Since this is blocked on a bug in the API - rather than leave this open I'm going to close this PR until we can proceed with this.

[paultyng]

@tombuildsstuff going to reopen this to look in to it again as there has been some renewed interest.

[tombuildsstuff]

Just re-ran the tests for this - the API still fails to provision App Service Environments after 30 hours:

Closing this PR since I don't see a path forward for it until this API is fixed

[tombuildsstuff]

Upstream API issue: Azure/azure-rest-api-specs#4915

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!