Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load balancer rule #25

Merged
merged 12 commits into from
Aug 13, 2018
Merged

Load balancer rule #25

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
16c34a0
Add LB rule resource
thetonymaster Aug 6, 2018
137485f
Merge branch 'master' into lb_rule
thetonymaster Aug 8, 2018
8f1df82
Merge branch 'lb_probe' into lb_rule
thetonymaster Aug 8, 2018
3f8382a
Merge branch 'master' into lb_rule
thetonymaster Aug 10, 2018
d8e9406
Style changes on variable snake_case->camelCase
thetonymaster Aug 10, 2018
d9c39ed
Add validations for required arguments
thetonymaster Aug 10, 2018
84c1fd4
Remove location from the lb rule tests
thetonymaster Aug 10, 2018
31e7257
Add lb rule documentation
thetonymaster Aug 10, 2018
046f1ca
Remove import test
thetonymaster Aug 10, 2018
43688b7
Change LoadBalancer->Load Balancer in lb rule documentation
thetonymaster Aug 10, 2018
8bc5626
Add more validations and refactor
thetonymaster Aug 13, 2018
e96aaec
Get probe_id and set the struct directly
thetonymaster Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions azurestack/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ func Provider() terraform.ResourceProvider {
"azurestack_lb_nat_rule": resourceArmLoadBalancerNatRule(),
"azurestack_lb_probe": resourceArmLoadBalancerProbe(),
"azurestack_lb_nat_pool": resourceArmLoadBalancerNatPool(),
"azurestack_lb_rule": resourceArmLoadBalancerRule(),
"azurestack_public_ip": resourceArmPublicIp(),
"azurestack_resource_group": resourceArmResourceGroup(),
"azurestack_storage_account": resourceArmStorageAccount(),
Expand Down
4 changes: 2 additions & 2 deletions azurestack/resource_arm_loadbalancer_probe_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestAccAzureStackLoadBalancerProbe_basic(t *testing.T) {
probeName := fmt.Sprintf("probe-%d", ri)

subscriptionID := os.Getenv("ARM_SUBSCRIPTION_ID")
probe_id := fmt.Sprintf(
probeID := fmt.Sprintf(
"/subscriptions/%s/resourceGroups/acctestRG-%d/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-%d/probes/%s",
subscriptionID, ri, ri, probeName)

Expand All @@ -32,7 +32,7 @@ func TestAccAzureStackLoadBalancerProbe_basic(t *testing.T) {
testCheckAzureStackLoadBalancerExists("azurestack_lb.test", &lb),
testCheckAzureStackLoadBalancerProbeExists(probeName, &lb),
resource.TestCheckResourceAttr(
"azurestack_lb_probe.test", "id", probe_id),
"azurestack_lb_probe.test", "id", probeID),
),
},
{
Expand Down
Loading