Add principles to roles #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malnick
force-pushed
the
users-groups-principle
branch
from
b259c94
to
9f456c3
Compare
talanknight
suggested changes
Jul 10, 2020
| } | ||
|
|
||
| if len(groupIDs) > 0 || len(userIDs) > 0 { | ||
| r, apiErr, err = r.SetPrincipals(ctx, groupIDs, userIDs) |
There was a problem hiding this comment.
This does clobber externally set roles... but I guess that is a problem with anything we are doing with TF so carry on :).
There was a problem hiding this comment.
Oh interesting, it should be idempotent for existing resources though. So basically what this will do is, if you have a role set and it has groups and users associated with it, this will override them, which is unexpected behavior.
malnick
force-pushed
the
users-groups-principle
branch
from
2ae62f2
to
f987d09
Compare
talanknight
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.