Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target alias resource #571

Merged
merged 2 commits into from
May 1, 2024
Merged

Add target alias resource #571

merged 2 commits into from
May 1, 2024

Conversation

talanknight
Copy link
Contributor

No description provided.

Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, however tests are failing because we are spinning up a version of Boundary without alias support it seems.

@louisruch
Copy link
Contributor

Also I made a couple updates to deps so you might need to rebase

@talanknight
Copy link
Contributor Author

FYI for anyone wondering why this PR is just sitting here: This PR shouldn't be merged until aliases are released in boundary.

@psekar psekar added this to the 0.16.0 milestone Apr 30, 2024
Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@talanknight talanknight merged commit 53c2a57 into main May 1, 2024
6 checks passed
@talanknight talanknight deleted the alanknight_alias_newresource branch May 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants