Remove duplicated function memory parameter (#9843) (#6894)

* Update firebaseextensions example * Formatting fix [upstream:76fe6896fb2b1cb218d6de00c8a9f956b2da6de9] Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Jan 23, 2024 · 1749df9 · 1749df9
1 parent 85dd3f9
commit 1749df9
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 17 deletions.
diff --git a/.changelog/9843.txt b/.changelog/9843.txt
@@ -0,0 +1,2 @@
+```release-note:none
+```
diff --git a/google-beta/services/firebaseextensions/resource_firebase_extensions_instance.go b/google-beta/services/firebaseextensions/resource_firebase_extensions_instance.go
@@ -99,7 +99,8 @@ emit, identified by their types.`,
 							Optional: true,
 							Description: `Params whose values are only available at deployment time.
 Unlike other params, these will not be set as environment variables on
-functions.`,
+functions. See a full list of system parameters at
+https://firebase.google.com/docs/extensions/publishers/parameters#system_parameters`,
 							Elem: &schema.Schema{Type: schema.TypeString},
 						},
 						"create_time": {

diff --git a/...-beta/services/firebaseextensions/resource_firebase_extensions_instance_generated_test.go b/...-beta/services/firebaseextensions/resource_firebase_extensions_instance_generated_test.go
@@ -77,7 +77,7 @@ resource "google_firebase_extensions_instance" "resize_image" {
   instance_id = "tf-test-storage-resize-images%{random_suffix}"
   config {
     extension_ref = "firebase/storage-resize-images"
-    extension_version = "0.1.37"
+    extension_version = "0.2.2"
 
     # The following params apply to the firebase/storage-resize-images extension. 
     # Different extensions may have different params
@@ -90,18 +90,17 @@ resource "google_firebase_extensions_instance" "resize_image" {
       DO_BACKFILL          = false
       IMG_SIZES            = "200x200"
       IMG_BUCKET           = google_storage_bucket.images.name
-      LOCATION             = "%{location}"
     }
 
     system_params = {
+      "firebaseextensions.v1beta.function/location"                   = "%{location}"
       "firebaseextensions.v1beta.function/maxInstances"               = 3000
-      "firebaseextensions.v1beta.function/memory"                     = 256
       "firebaseextensions.v1beta.function/minInstances"               = 0
       "firebaseextensions.v1beta.function/vpcConnectorEgressSettings" = "VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED"
     }
 
     allowed_event_types = [
-      "firebase.extensions.storage-resize-images.v1.complete"
+      "firebase.extensions.storage-resize-images.v1.onCompletion"
     ]
 
     eventarc_channel = "projects/%{project_id}/locations/%{location}/channels/firebase"

diff --git a/google-beta/services/firebaseextensions/resource_firebase_extensions_instance_test.go b/google-beta/services/firebaseextensions/resource_firebase_extensions_instance_test.go
@@ -66,7 +66,7 @@ resource "google_firebase_extensions_instance" "resize_image" {
   instance_id = "tf-test-storage-resize-images%{random_suffix}"
   config {
     extension_ref = "firebase/storage-resize-images"
-    extension_version = "0.1.37"
+    extension_version = "0.2.2"
 
     # The following params apply to the firebase/storage-resize-images extension. 
     # Different extensions may have different params
@@ -79,18 +79,17 @@ resource "google_firebase_extensions_instance" "resize_image" {
       DO_BACKFILL          = false
       IMG_SIZES            = "200x200"
       IMG_BUCKET           = google_storage_bucket.images.name
-      LOCATION             = "%{location}"
     }
 
     system_params = {
+      "firebaseextensions.v1beta.function/location"                   = "%{location}"
       "firebaseextensions.v1beta.function/maxInstances"               = 3000
-      "firebaseextensions.v1beta.function/memory"                     = 256
       "firebaseextensions.v1beta.function/minInstances"               = 0
       "firebaseextensions.v1beta.function/vpcConnectorEgressSettings" = "VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED"
     }
 
     allowed_event_types = [
-      "firebase.extensions.storage-resize-images.v1.complete"
+      "firebase.extensions.storage-resize-images.v1.onCompletion"
     ]
 
     eventarc_channel = "projects/%{project_id}/locations/%{location}/channels/firebase"
@@ -118,7 +117,7 @@ resource "google_firebase_extensions_instance" "resize_image" {
   instance_id = "tf-test-storage-resize-images%{random_suffix}"
   config {
     extension_ref = "firebase/storage-resize-images"
-    extension_version = "0.1.37"
+    extension_version = "0.2.2"
 
     # The following params apply to the firebase/storage-resize-images extension. 
     # Different extensions may have different params
@@ -132,13 +131,12 @@ resource "google_firebase_extensions_instance" "resize_image" {
       DO_BACKFILL          = true
       IMG_SIZES            = "400x400"
       IMG_BUCKET           = google_storage_bucket.images.name
-      LOCATION             = "%{location}"
     }
 
     system_params = {
+      "firebaseextensions.v1beta.function/location"                   = "%{location}"
       # Changed params
       "firebaseextensions.v1beta.function/maxInstances"               = 100
-      "firebaseextensions.v1beta.function/memory"                     = 128
       "firebaseextensions.v1beta.function/minInstances"               = 0
       "firebaseextensions.v1beta.function/vpcConnectorEgressSettings" = "VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED"
     }

diff --git a/website/docs/r/firebase_extensions_instance.html.markdown b/website/docs/r/firebase_extensions_instance.html.markdown
@@ -50,7 +50,7 @@ resource "google_firebase_extensions_instance" "resize_image" {
   instance_id = "storage-resize-images"
   config {
     extension_ref = "firebase/storage-resize-images"
-    extension_version = "0.1.37"
+    extension_version = "0.2.2"
 
     # The following params apply to the firebase/storage-resize-images extension. 
     # Different extensions may have different params
@@ -63,18 +63,17 @@ resource "google_firebase_extensions_instance" "resize_image" {
       DO_BACKFILL          = false
       IMG_SIZES            = "200x200"
       IMG_BUCKET           = google_storage_bucket.images.name
-      LOCATION             = ""
     }
 
     system_params = {
+      "firebaseextensions.v1beta.function/location"                   = ""
       "firebaseextensions.v1beta.function/maxInstances"               = 3000
-      "firebaseextensions.v1beta.function/memory"                     = 256
       "firebaseextensions.v1beta.function/minInstances"               = 0
       "firebaseextensions.v1beta.function/vpcConnectorEgressSettings" = "VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED"
     }
 
     allowed_event_types = [
-      "firebase.extensions.storage-resize-images.v1.complete"
+      "firebase.extensions.storage-resize-images.v1.onCompletion"
     ]
 
     eventarc_channel = "projects/my-project-name/locations//channels/firebase"
@@ -116,7 +115,8 @@ The following arguments are supported:
   (Optional)
   Params whose values are only available at deployment time.
   Unlike other params, these will not be set as environment variables on
-  functions.
+  functions. See a full list of system parameters at
+  https://firebase.google.com/docs/extensions/publishers/parameters#system_parameters
 
 * `extension_ref` -
   (Required)