Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource: google_compute_backend_service: max_rate interface conversion panic #3590

Closed
olivierboucher opened this issue May 8, 2019 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#1750
Assignees
Labels

Comments

@olivierboucher
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.11.13

  • provider.google v2.6.0
  • provider.google-beta v2.6.0

Affected Resource(s)

google_compute_backend_service

Terraform Configuration Files

resource "google_compute_backend_service" "go_clicks" {
  provider = "google-beta"

  name          = "go-clicks"
  description   = "backend service for go-clicks from different clusters"
  health_checks = ["${google_compute_health_check.go_clicks.self_link}"]

  load_balancing_scheme = "EXTERNAL"

  // The backends are HTTP, we don't care about traffic being encrypted or not
  // while it travels internally. This the setting the Ingress controller was using.
  protocol = "HTTP"

  timeout_sec = 30

  backend = [
    {
      max_rate = 99999
      balancing_mode = "RATE"
      group          = "projects/eflow-dev/zones/us-central1-c/networkEndpointGroups/${google_compute_network_endpoint_group.test_cluster_1_go_clicks.id}"
    },
  ]
}

Debug Output

https://gist.github.com/olivierboucher/34cb776a4026145ddb2922056b9bfdac

Panic Output

https://gist.github.com/olivierboucher/87eae0229d443972625d8cd6f350fd7f

Expected Behavior

The plugin should parse the max_rate value properly

Actual Behavior

It crashes because there's a type cast to int but the type is a float64

Steps to Reproduce

  1. terraform apply

Important Factoids

References

@ghost ghost added the bug label May 8, 2019
@chrisst chrisst self-assigned this May 10, 2019
@chrisst chrisst changed the title Resource: google_compute_network_endpoint_group: max_rate interface conversion panic Resource: google_compute_backend_service: max_rate interface conversion panic May 10, 2019
@ghost
Copy link

ghost commented Jun 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants