Change the hash function to be more format tolerant #1750
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Hmm I wonder how I convinced myself %v wouldn't work in the first place, especially since I used it like a line above lol https://github.com/GoogleCloudPlatform/magic-modules/pull/1750/files#diff-011a1a0eb6ed45e262201b827e9fa4f2L94
tested in CI and tests looked green + logs made sense 👍
chrisst
force-pushed
the
backend-service-hash
branch
from
fea6800 to
32d9628
Compare
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
The Go json library will parse numbers as floats, however the schema dictates that these values are integers. In order to be agnostic to to the contents the ints can be printed directly to strings without needing to be cast first.
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
backend-service-hash
branch
from
32d9628 to
c13446f
Compare
The Go json library will parse numbers as floats, however the schema dictates
that these values are integers. In order to be agnostic to to the contents
the ints can be printed directly to strings without needing to be cast first.
I can't test this right now because the backend service API is having a hard time. However here's a proof of concept for how the data should work: https://play.golang.org/p/qFoXogo3FS6
Fixes hashicorp/terraform-provider-google#3590
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]