Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_dns_record_set - type "DS" is not expected type #8897

Labels

Comments

@jlam-bills
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.14.5
+ provider registry.terraform.io/hashicorp/google v3.63.0
+ provider registry.terraform.io/hashicorp/google-beta v3.64.0

Your version of Terraform is out of date! The latest version
is 0.14.10. You can update by downloading from https://www.terraform.io/downloads.html

Affected Resource(s)

  • google_dns_record_set

Terraform Configuration Files

resource "google_dns_record_set" "ds_records" {
  for_each = {
    "dev" = ["<some_ds_record>"],
    "prd" = ["<some_ds_record>"],
    "stg" = ["<some ds record>"],
  }

  project      = <some_project_id>
  managed_zone = google_dns_managed_zone.<some_zone>.name
  ttl          = 300
  name         = "${each.key}.${google_dns_managed_zone.<some_zone>.dns_name}"
  rrdatas      = each.value
  type         = "DS"

Debug Output

Panic Output

Expected Behavior

The expected behavior from "terraform validate" should pass. "DS" is a valid DNS record type (reference doc)

Actual Behavior

Error: expected type to be one of [A AAAA CAA CNAME MX NAPTR NS PTR SOA SPF SRV TLSA TXT], got DS

Steps to Reproduce

  1. terraform validate

Important Factoids

We downgraded the provider to use version 3.63.0 rather than using the latest version (3.64.0).

    google = {
      source  = "hashicorp/google"
      version = "~> 3.63.0"
    }

References

@ghost ghost added the bug label Apr 13, 2021
rjw57 added a commit to rjw57/magic-modules that referenced this issue Apr 13, 2021
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes hashicorp/terraform-provider-google#8897
@rjw57
Copy link

rjw57 commented Apr 13, 2021

I opened GoogleCloudPlatform/magic-modules#4689 which should fix this. Looks like it's just an incomplete whitelist in the magic modules service spec.

melinath pushed a commit to GoogleCloudPlatform/magic-modules that referenced this issue Apr 14, 2021
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes hashicorp/terraform-provider-google#8897
modular-magician added a commit to modular-magician/inspec-gcp that referenced this issue Apr 15, 2021
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes hashicorp/terraform-provider-google#8897

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/inspec-gcp that referenced this issue Apr 15, 2021
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes hashicorp/terraform-provider-google#8897

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/google.cloud that referenced this issue Apr 15, 2021
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes hashicorp/terraform-provider-google#8897

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to ansible-collections/google.cloud that referenced this issue Apr 15, 2021
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes hashicorp/terraform-provider-google#8897

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Apr 15, 2021
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes hashicorp#8897

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this issue Apr 15, 2021
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes hashicorp/terraform-provider-google#8897

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Apr 15, 2021
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes #8897

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this issue Apr 15, 2021
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes hashicorp/terraform-provider-google#8897

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented May 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.