Add workload_pool to google_container_cluster, deprecate identity_namespace #10327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was stuck on how to migrate this safely while making the fields O+C, as it's an intended mechanic that
identity_namespace
can be set to""
to disable the feature. For better or for worseworkload_identity_config
is O+C and I don't want to change that here.I went with making both fields optional, and conditionally writing the value into state based on what the user set. They can specify one, none, or both of the fields and all are valid states. If they've specified
identity_namespace
, they'll get a deprecation warning. This adds a diff that wouldn't be present with O+C, where a user has to approve a plan that transitions from one set of fields set to the other.These fields are a little weird, also, they're strings but can only be set to a single project-dependent value. Otherwise I'd need a conflicts.
Some basic workflows:
identity_namespace
if the value is presentIf this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#5317