Enable retries for QueryOp(...) calls #4605
Conversation
google/common_operation.go
Outdated
| @@ -109,6 +110,13 @@ func CommonRefreshFunc(w Waiter) resource.StateRefreshFunc { | |||
| return op, "done: false", nil | |||
| } | |||
|
|
|||
| for _, e := range getAllTypes(err, &googleapi.Error{}, &url.Error{}) { | |||
| if isRetryableError(e, nil) { | |||
There was a problem hiding this comment.
While you're here, do you mind making the 404 condition above a retry predicate and passing it in to isRetryableError?
The reason we retry those 404's is that operations don't always exist immediately.
|
Updated with conversion of the 404 check to predicate and formatting of test file. |
|
Sorry for the delay! We were in a short-term freeze for the |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
The CommonRefreshFunc(...) queries the operation and then immediately returns in error if any sort of http timeout occurs when querying.