Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage bucket iam generation #5099

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Dec 6, 2019

Original Author: @danawillow

storage: updated `id` and `bucket` fields for `google_storage_bucket_iam_*` resources to use `b/{bucket_name}`

Signed-off-by: Modular Magician <magic-modules@google.com>
@danawillow danawillow merged commit 05d2e0d into hashicorp:master Dec 13, 2019
@natalysheinin
Copy link

I believe this PR caused breaking changes that resulted in errors when planning with the resource "google_storage_bucket_iam_member" resource:

Error: Error reading Resource "Storage Bucket \"b/bucket-abc\"" with IAM Member: Role "roles/storage.objectViewer" Member "serviceAccount:name-here@gcp-project.iam.gserviceaccount.com": Error retrieving IAM policy for Storage Bucket "b/bucket-abc": googleapi: Error 400: "projects/_/buckets/b/bucket-abc" is not a valid resource name. A resource name must be specified in one of the following forms: 'buckets/<your bucket>', 'buckets/<your bucket>/objects/<your object', 'buckets/<your bucket>/objects/<your object>#<generation number>', invalid

@danawillow
Copy link
Contributor

@natalysheinin can you file a new bug that fills out the template and links back to this PR as a possible culprit? That'll make sure we're able to track the fix.

@ghost
Copy link

ghost commented Jan 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants