Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In resource_google_project: Fix one bug with retries to Projects.Update(...) and add retries to GetBillingInfo(...) requests #5578

Merged
merged 1 commit into from
Feb 7, 2020

Commits on Feb 6, 2020

  1. In resource_google_project: Fix one bug with retries to Projects.Upda…

    …te(...) and add retries to GetBillingInfo(...) requests
    
    This change affects two areas::
    1. When the result of a Projects.Update(...) request is an error, the returned
        'project' value is 'nil'. Previously, this value was stored in 'p' which
        was then dereferenced when retrieving 'p.ProjectId' on the subsequent retry.
        This fix only allows 'p' to be overwritten if the Projects.Update(...)
        request is successful.
    2. Requests to the BillingInfo service could fail due to transient HTTP timeouts
       (usually TLS handshake negotiation timeout) and for throttling (HTTP
       429). Adding retries addresses this.
    spew committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    d1e4587 View commit details
    Browse the repository at this point in the history