Fix bug: diff being detected for source_repo_repository even when there are no changes #6886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug in source_repo_repository where a diff was always being generated for the TypeSet field
pubsub_configs
since its Set hashing function was not accounting for the fact thatpubsub_configs[].topic
can contain either a topic's name or relative path.To reproduce, apply the following Terraform configuration, then run
terraform plan
right after. Notice howterraform plan
detects a diff even when nothing was actually changed.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3786