-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds serviceusage api in precheck function #7447
Conversation
…se. If it is not enabled network deletion will fail and project will be marked as taint
Hello folks, |
…rror when api is not enabled
…nd for error when api is not enabled" This reverts commit 374b39b.
Hi guys, Please, let me know if you want any additional changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've got to upstream this to Magic Modules so it applies to both providers. I'll do that, then merge here.
@thiagonache @rileykarson do the http error codes differ between the two switch cases? Perhaps checking that would be a more reliable method than checking error strings, which could change without notice. |
No. it's both 403, I also considered it. Unfortunately, the error type and the HTTP response code are the same. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR address the issue #6222.