Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds serviceusage api in precheck function #7447

Merged
merged 7 commits into from
Oct 8, 2020
Merged

Adds serviceusage api in precheck function #7447

merged 7 commits into from
Oct 8, 2020

Conversation

thiagonache
Copy link
Contributor

This PR address the issue #6222.

…se. If it is not enabled network deletion will fail and project will be marked as taint
@ghost ghost added size/xs labels Oct 7, 2020
@ghost ghost requested review from slevenick and rileykarson October 7, 2020 00:57
@thiagonache
Copy link
Contributor Author

thiagonache commented Oct 7, 2020

Hello folks,
It is a simple check that we need to perform in the provider in order to disable local execs we have in the project-factory module. It is just adding couple lines of code. All the details can be found on the issue mentioned in the PR.
Please, let me know any considerations.

@thiagonache thiagonache marked this pull request as ready for review October 7, 2020 03:17
google/resource_google_project.go Outdated Show resolved Hide resolved
google/resource_google_project.go Outdated Show resolved Hide resolved
…nd for error when api is not enabled"

This reverts commit 374b39b.
@thiagonache
Copy link
Contributor Author

Hi guys,

Please, let me know if you want any additional changes.

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've got to upstream this to Magic Modules so it applies to both providers. I'll do that, then merge here.

@umairidris
Copy link
Contributor

umairidris commented Oct 8, 2020

@thiagonache @rileykarson do the http error codes differ between the two switch cases? Perhaps checking that would be a more reliable method than checking error strings, which could change without notice.

@thiagonache
Copy link
Contributor Author

thiagonache commented Oct 8, 2020

@thiagonache @rileykarson do the http error codes differ between the two switch cases? Perhaps checking that would be a more reliable method than checking error strings, which could change without notice.

No. it's both 403, I also considered it. Unfortunately, the error type and the HTTP response code are the same.
Thank you very much for asking it.

@ghost
Copy link

ghost commented Nov 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants