Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the privateca certificate template resource. #9905

Conversation

modular-magician
Copy link
Collaborator

  • update serialization code so that the sample test can be autogenerated.
  • fix minor issues in samples generation code (underscores vs title vase)
  • add privateca to provider
  • add ability to expand and flatten int arrays.
  • remove cloud run serialization (and relevant tests) since it no longer exists in the DCL.

Fixes #9607

Replace each [ ] with [X] to check it. Switch to the preview view to make it easier to click on links.
These steps will speed up the review process, and we appreciate you spending time on them before sending
your code to be reviewed.
-->
If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_privateca_certificate_template`

Derived from GoogleCloudPlatform/magic-modules#5109

* Add the privateca certificate template resource.

* update serialization code so that the sample test can be autogenerated.
* fix minor issues in samples generation code (underscores vs title vase)
* add privateca to provider
* add ability to expand and flatten int arrays.
* remove cloud run serialization (and relevant tests) since it no longer exists in the DCL.

* add go.sum entry for new dcl.

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>

* Add beta version of privateca certificate template.

* Update serialization.

* Upgrade to version of DCL that can handle pointers to objects which are set but contain only fields which are set but empty.

Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit c3eb6e9 into hashicorp:master Aug 25, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PrivateCA Certificate Templates
1 participant