Add RequiresReplace attribute for secret_name in hvs secret resource #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcoulombe
reviewed
Dec 18, 2024
| @@ -76,6 +76,9 @@ func (r *resourceVaultsecretsSecret) Schema(_ context.Context, _ resource.Schema | |||
| "must contain only ASCII letters, numbers, and underscores; must not start with a number", | |||
| ), | |||
| }, | |||
| PlanModifiers: []planmodifier.String{ | |||
| stringplanmodifier.RequiresReplace(), | |||
| }, | |||
There was a problem hiding this comment.
We should add this to the app_name since it is not a modifiable field either.
Can we add tests for that scenario? Something like a CheckDestroy that verifies the secret with the old name no longer exists after the rename is applied. A good rule of thumb is 1 regression = 1 new test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
If you change the name of a hcp_vault_secrets_secret it is expected that the secret with the previous name gets deleted and the a secret with the new name gets created. However, the TF provider treats it as an update and creates the new secret while not deleting the previous one. This change adds a fix for this.
JIRA: https://hashicorp.atlassian.net/browse/HV-3235
🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX' ...Local test where I changed the app name and secret name, terraform plan shows 2 to be added and 2 to be destroyed
