-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server certificate validation with Root CA and insecure option #29
Add server certificate validation with Root CA and insecure option #29
Conversation
This would be an extremely helpful addition given the number of missing data objects in a number of the providers. (Most notably the Kubernetes provider which lacks data equivalents to almost every resource it can make) At the moment in order to work around missing Kubernetes data sources (In order to query things created with the helm provider) I have to work around the lack of TLS support by using the shell provider and using curl directly. |
84ab348
to
18aae20
Compare
Any chance to see this PR reviewed or at least close it if it doesn't make sense here ? |
79f3790
to
d3c1418
Compare
Is there any current workaround while we wait for this to get merged? |
@jonatan-b-kr I had to use the shell provider and curl in order to get around this. Its not a very good workaround because of the limitations of the shell provider. |
d3c1418
to
cc46692
Compare
It's almost 10 months now since this PR is open without any comment from the maintainer. Is this something we want to merge in ? If yes, how can the PR be review ? If not, please tell me so I close this PR and move on another solution. |
Maybe @apparentlymart could help ? |
@paultyng please advise. |
9c932c6
to
0a84c06
Compare
@kmoe any chance to review this PR ? |
8123e1b
to
29516b4
Compare
This would be really useful if it could be merged? |
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Thierno BARRY seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
@barryib perhaps this is still pending awaiting contribution attribution for the CLA |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR will let user validate TLS certificate with a provided root CA or choose a
insecure
option with no validation at all.May solves hashicorp/terraform-provider-aws#11426 and have a lot of common usage.
Link for tests terraform-aws-modules/terraform-aws-eks#1339