Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TC test issue from SDKv2 upgrade #1055

Merged
merged 7 commits into from
Nov 12, 2020
Merged

Conversation

dak1n1
Copy link
Contributor

@dak1n1 dak1n1 commented Nov 4, 2020

Description

This PR fixes an issue surfaced in the SDKv2 upgrade PR, where a test was masking potential errors.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

=== RUN   TestAccKubernetesPersistentVolumeClaim_googleCloud_volumeMatch
--- PASS: TestAccKubernetesPersistentVolumeClaim_googleCloud_volumeMatch (79.56s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_googleCloud_volumeUpdate
--- PASS: TestAccKubernetesPersistentVolumeClaim_googleCloud_volumeUpdate (69.40s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_googleCloud_storageClass
--- PASS: TestAccKubernetesPersistentVolumeClaim_googleCloud_storageClass (12.49s)
=== RUN   TestAccKubernetesPersistentVolume_googleCloud_basic
--- PASS: TestAccKubernetesPersistentVolume_googleCloud_basic (62.77s)
=== RUN   TestAccKubernetesPersistentVolume_googleCloud_volumeSource
--- PASS: TestAccKubernetesPersistentVolume_googleCloud_volumeSource (72.74s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   297.020s

Release Note

Release note for CHANGELOG:

NONE

References

#1027

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added size/M labels Nov 4, 2020
And allow setting a username/password instead of client cert.
@dak1n1
Copy link
Contributor Author

dak1n1 commented Nov 5, 2020

TC is running with Terraform 0.14-beta2 now. https://ci-oss.hashicorp.engineering/viewLog.html?buildId=156236

@dak1n1 dak1n1 changed the title [WIP] TC tests for version 2 TC tests for version 2 Nov 5, 2020
@dak1n1 dak1n1 changed the title TC tests for version 2 Fix TC test issue from SDKv2 upgrade Nov 5, 2020
@dak1n1 dak1n1 requested a review from a team November 5, 2020 20:52
@ghost ghost added documentation labels Nov 6, 2020
strings.Join([]string{
"KUBE_LOAD_CONFIG_FILE=false",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're removing the load_config_file option so I think we can leave this out.

@dak1n1 dak1n1 merged commit f7d2f8d into hashicorp:master Nov 12, 2020
@ghost
Copy link

ghost commented Dec 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants