-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TC test issue from SDKv2 upgrade #1055
Conversation
And allow setting a username/password instead of client cert.
TC is running with Terraform 0.14-beta2 now. https://ci-oss.hashicorp.engineering/viewLog.html?buildId=156236 |
kubernetes/provider_test.go
Outdated
strings.Join([]string{ | ||
"KUBE_LOAD_CONFIG_FILE=false", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're removing the load_config_file option so I think we can leave this out.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Description
This PR fixes an issue surfaced in the SDKv2 upgrade PR, where a test was masking potential errors.
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
#1027
Community Note