-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensitive option to local_file to suppress output in plan #101
Conversation
…content and redirect to sensitive_content
6329b7a
to
35bc87a
Compare
@teamterraform, Any update on this? I have need of this because control-characters that show up in the output can break Jenkins executions of the terraform... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jhancock93, thanks for this.
So, this is great, and I left some comments inline.
NOTE: the website documentation needs updating (i.e. this). The update should reflect the new attributes, as well as an example usage. Please also make sure the doc explains the "mutually exclusive" nature of setting sensitive = true
Thanks @detro. I have updated the documentation as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is progressing great. Just left a few more comments, but we are pretty much looking at the runway for a smooth landing :)
Committing suggested documentation changes. Co-authored-by: Ivan De Marino <ivan.de.marino@gmail.com>
7ee68d7
to
5a60228
Compare
@detro, I think I have addressed all your feedback. Let me know if anything else is needed before merging! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you so much for this contribution
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add sensitive boolean attribute to data source local_file to output to sensitive_content field instead of content field.
Closes #36
Closes #64