Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #123

Merged
merged 7 commits into from
May 18, 2022
Merged

Update docs #123

merged 7 commits into from
May 18, 2022

Conversation

stdtom
Copy link
Contributor

@stdtom stdtom commented Apr 30, 2022

Update docs to prevent confusion that exactly one of the arguments content,
sensitive_content, content_base64, and source needs to be specified.

Closes #116 and #122

@stdtom stdtom requested a review from a team as a code owner April 30, 2022 12:34
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 30, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @stdtom - thank you so much for taking the time with this.

Would you mind adding a note for the next CHANGELOG entry, to specify the important documentation improvement you are introducing?

I think it should go under the NOTES: section.
And the next CHANGELOG entry should be for 2.2.3 I believe (being this a patch release).

@stdtom
Copy link
Contributor Author

stdtom commented May 14, 2022

Hi @detro
I added a changelog entry - hope it meets your expextations.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@detro detro merged commit 30e4f77 into hashicorp:main May 18, 2022
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The local provider documentation are not up-to-date
3 participants