Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch linting from go vet to golangci-lint #237

Closed
1 task done
bendbennett opened this issue Apr 25, 2022 · 1 comment · Fixed by #240
Closed
1 task done

Switch linting from go vet to golangci-lint #237

bendbennett opened this issue Apr 25, 2022 · 1 comment · Fixed by #240
Labels
enhancement
Milestone
v3.2.0

Comments

@bendbennett
Copy link
Contributor

Terraform CLI and Provider Versions

Terraform v1.1.8
Provider v3.1.3

Use Cases or Problem Statement

Currently, go vet is being used for linting.

Proposal

Switch to using golangci-lint in order to align linting across the utility providers (e.g., tls, random).

How much impact is this issue causing?

Low

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bendbennett bendbennett added this to the v3.2.0 milestone Apr 25, 2022
bendbennett added a commit that referenced this issue Apr 25, 2022
@bendbennett
Adding golangci-lint configuration and make command (#237)
196f879
bendbennett added a commit that referenced this issue Apr 25, 2022
@bendbennett
Switching to using golangci-lint during CI (#237)
e7b30f6
@bendbennett bendbennett mentioned this issue Apr 25, 2022
Merged
bendbennett added a commit that referenced this issue Apr 25, 2022
@bendbennett
Fixing linting errors (#237)
501d48e
@vfoucault vfoucault mentioned this issue May 10, 2022
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging a pull request may close this issue.

Switch linting from go vet to golangci-lint hashicorp/terraform-provider-random
1 participant
@bendbennett