This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
ci: replace forked GH action with latest upstream #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't remember the full context of the impetus, but I believe the fork was also there so folks could "trust" the GitHub Action in question since it was coming from HashiCorp and not a third-party, since its dealing with sensitive information. |
|
In regard to https://github.com/hashicorp/terraform-provider-scaffolding/blob/main/.github/workflows/add-content-to-project.yml it's intentional: it should add any incoming PR/issue to all TF DevEx team, to our internal project. Though I'm noticing, this thing hasn't triggered with you here. There might be an issue with it: I'll look into it. |
This was referenced Jun 14, 2022
Merged
bflad
approved these changes
Jul 15, 2022
jon-ruckwood
added a commit
to juju/terraform-provider-juju
that referenced
this pull request
Jul 18, 2022
Hashicorp's ghaction-import-gpg has been deprecated in favour of this action - additionally their action has a bug which they are not intending on fixing and recommend people switch. Reference: hashicorp/terraform-provider-scaffolding#127 Reference: hashicorp/ghaction-import-gpg#11
jon-ruckwood
added a commit
to juju/terraform-provider-juju
that referenced
this pull request
Jul 18, 2022
Hashicorp's ghaction-import-gpg has been deprecated in favour of this action - additionally their action has a bug which they are not intending on fixing and recommend people switch. Reference: hashicorp/terraform-provider-scaffolding#127 Reference: hashicorp/ghaction-import-gpg#11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main blocker and reason for the fork (support of subkeys) seems to be resolved now:
crazy-max/ghaction-import-gpg#58
Unrelated: I noticed this action also, which doesn't seem relevant for this repo - was that perhaps accidentally copied from somewhere else?